Skip to content

Add the UI for merging PDFs (bug 2028071) - #21060

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:implement_merge
Apr 13, 2026
Merged

Add the UI for merging PDFs (bug 2028071)#21060
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:implement_merge

Conversation

@calixteman

@calixteman calixteman commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@calixteman
calixteman requested a review from a team as a code owner April 7, 2026 15:27
@codecov-commenter

codecov-commenter commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 6 lines in your changes missing coverage. Please review.
βœ… Project coverage is 63.36%. Comparing base (96debf0) to head (8c9b819).

Files with missing lines Patch % Lines
src/core/editor/pdf_editor.js 95.65% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21060      +/-   ##
==========================================
+ Coverage   63.31%   63.36%   +0.04%     
==========================================
  Files         177      177              
  Lines      124732   124820      +88     
==========================================
+ Hits        78980    79094     +114     
+ Misses      45752    45726      -26
Flag Coverage Ξ”
fonttest 7.64% <ΓΈ> (ΓΈ)
unittestcli 63.34% <95.65%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman changed the title Add the UI for merging PDFs Add the UI for merging PDFs (bug 2028071) Apr 7, 2026
Snuffleupagus
Snuffleupagus reviewed Apr 7, 2026
View reviewed changes
Comment thread web/pdf_thumbnail_viewer.js Resolved
@timvandermeij
timvandermeij self-requested a review April 9, 2026 19:32
@timvandermeij

timvandermeij commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

moz-tools-bot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5b487dcf9f0286e/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5b487dcf9f0286e/output.txt

Total script time: 1.22 mins

Published

timvandermeij
timvandermeij reviewed Apr 9, 2026
View reviewed changes
Comment thread test/integration/reorganize_pages_spec.mjs Resolved
Comment thread web/pdf_thumbnail_viewer.js Resolved
Comment thread web/viewer.html Resolved
@calixteman

calixteman commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

/botio-linux integration-test

@calixteman

calixteman commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

/botio-linux integrationtest

@moz-tools-bot

moz-tools-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b2e6f939d410ebb/output.txt

@mozilla mozilla deleted a comment from moz-tools-bot Apr 13, 2026
@moz-tools-bot

moz-tools-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b2e6f939d410ebb/output.txt

Total script time: 28.74 mins

  • Integration Tests: FAILED

@timvandermeij
timvandermeij self-requested a review April 13, 2026 18:34
@timvandermeij

timvandermeij commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

moz-tools-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6f461557b26dace/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6f461557b26dace/output.txt

Total script time: 1.21 mins

Published

timvandermeij
timvandermeij approved these changes Apr 13, 2026
View reviewed changes

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the final comments addressed.

Comment thread web/pdf_thumbnail_viewer.js Resolved
Comment thread test/integration/reorganize_pages_spec.mjs Resolved
@calixteman
calixteman merged commit b82ceda into mozilla:master Apr 13, 2026
14 checks passed
@calixteman
calixteman deleted the implement_merge branch April 13, 2026 19:37
@timvandermeij timvandermeij mentioned this pull request Oct 2, 2026
Merged

This branch was previously deployed

1 inactive deployment
code-coverage β€” 8c9b819b Deployed Apr 13, 2026 by calixteman via Test (lts/*) #1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments
@timvandermeij timvandermeij timvandermeij approved these changes
@bcolsson bcolsson bcolsson approved these changes

Assignees

No one assigned

Labels

split-merge-organize

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@calixteman @codecov-commenter @timvandermeij @moz-tools-bot @Snuffleupagus @bcolsson