Repository navigation
Add support for function-based shadings (bug 1254066) - #21012
Conversation
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21012 +/- ##
==========================================
+ Coverage 63.25% 63.36% +0.11%
==========================================
Files 176 176
Lines 124540 124696 +156
==========================================
+ Hits 78777 79013 +236
+ Misses 45763 45683 -80
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
3f8ca58 to
b5f2eed
Compare
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
b5f2eed to
b4e60bc
Compare
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the merge conflict and the comments addressed. Thank you for implementing this, and adding test coverage!
It fixes mozilla#5046. We just generate a mesh for the pattern rectangle where the color of each vertex is computed from the function. Since the mesh is generated in the worker we don't really take into account the current transform when it's drawn. That being said, there are maybe some possible improvements in using directly the gpu for the shading creation which could then take into account the current transform, but it could only work with ps function we can convert ino wgsl language and simple enough color spaces (gray and rgb).
b4e60bc to
3727b70
Compare
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc1bc289e121125/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9ab8fb8b6748523/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cc1bc289e121125/output.txt Total script time: 46.40 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9ab8fb8b6748523/output.txt Total script time: 77.64 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 2 Live output at: http://54.241.84.105:8877/6226ae729340ce0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/857648e7def173c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6226ae729340ce0/output.txt Total script time: 18.21 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/857648e7def173c/output.txt Total script time: 26.39 mins
|
|
It fixes #5046.
We just generate a mesh for the pattern rectangle where the color of each vertex is computed from the function.
Since the mesh is generated in the worker we don't really take into account the current transform when it's drawn.
That being said, there are maybe some possible improvements in using directly the gpu for the shading creation
which could then take into account the current transform, but it could only work with ps function we can convert
ino wgsl language and simple enough color spaces (gray and rgb).