Skip to content

Add the possibility to drag & drop some thumbnails in the pages view (bug 2009573) - #20559

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:new_sidebar2
Jan 14, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:new_sidebar2

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

The goal is to be able to reorganize the pages in a pdf.

@calixteman
calixteman force-pushed the new_sidebar2 branch 3 times, most recently from 1b687b4 to a2813f2 Compare January 7, 2026 15:15
@timvandermeij

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/137d5535c3b7b5d/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/137d5535c3b7b5d/output.txt

Total script time: 1.01 mins

Published

@calixteman
calixteman force-pushed the new_sidebar2 branch 2 times, most recently from 66f726e to 0726e38 Compare January 9, 2026 15:58
@marco-c marco-c changed the title Add the possibility to drag & drop some thumbnails in the pages view Add the possibility to drag & drop some thumbnails in the pages view (bug 2009573) Jan 10, 2026

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comments addressed and passing integration tests. Thank you!

Comment thread test/integration/jasmine-boot.js Resolved
Comment thread web/pdf_thumbnail_viewer.js Resolved
Comment thread web/pdf_thumbnail_viewer.js Resolved
Comment thread web/pdf_thumbnail_viewer.js Resolved
Comment thread web/pdf_viewer.js Resolved
Comment thread web/ui_utils.js Resolved
Comment thread web/views_manager.css Resolved
@calixteman

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/97e785bab57a86c/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e450771a2707d5/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2e450771a2707d5/output.txt

Total script time: 21.02 mins

  • Integration Tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/97e785bab57a86c/output.txt

Total script time: 45.84 mins

  • Integration Tests: FAILED

@calixteman

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a952f046da0a6db/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c01b579e516330b/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/c01b579e516330b/output.txt

Total script time: 21.08 mins

  • Integration Tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a952f046da0a6db/output.txt

Total script time: 45.87 mins

  • Integration Tests: FAILED

@calixteman

Copy link
Copy Markdown
Contributor Author

/botio-windows integrationtest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3a42fb1dee2150d/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3a42fb1dee2150d/output.txt

Total script time: 5.05 mins

  • Integration Tests: FAILED

The goal is to be able to reorganize the pages in a pdf.
@calixteman

Copy link
Copy Markdown
Contributor Author

/botio integrationtest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cb816f24639459e/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/617512f76468eb4/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/cb816f24639459e/output.txt

Total script time: 21.13 mins

  • Integration Tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/617512f76468eb4/output.txt

Total script time: 45.10 mins

  • Integration Tests: FAILED

@calixteman
calixteman merged commit 67673ea into mozilla:master Jan 14, 2026
8 checks passed
@calixteman
calixteman deleted the new_sidebar2 branch January 14, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants