Repository navigation
Drop JUnit 4, the vintage engine and Hamcrest from the plugin tests - #1427
Merged
Merged
Conversation
slachiewicz
force-pushed
the
agent/junit4-out
branch
from
October 10, 2026 19:59
1103156 to
4b58b3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1414, step 3.
After #1425 no test in
versions-maven-pluginuses JUnit 4 or Hamcrest, sojunit:junit,junit-vintage-engineandorg.hamcrest:hamcrestleave its test dependencies. The last two deprecation warnings of the test sources go as well:PluginUpdatesReportTestreads the reporting plugins from the model, andTestWagonStubsuppresses the warning onopenConnection(), which theWagoninterface still declares.The one deprecation warning left in the build is
getDependencyArtifacts()inAbstractVersionsDependencyUpdaterMojo, which #1420 left for a change of its own.versions-commonandversions-enforcerstill use Hamcrest in their tests; #1414 tracks them.Verified:
mvn clean install -Dinvoker.skip→ all modules pass, 297 tests in the plugin run on the JUnit 5 engine alone, 0 Checkstyle violations