Repository navigation
Use maven-plugin-plugin in version managed in parent - #97
Merged
Merged
Conversation
Contributor
Author
|
May I ask for review, please? |
stefanseifert
self-requested a review
July 14, 2020 13:20
Collaborator
|
makes sense! a release of this mojo-parent is planned soon, i think it would be best to update to this next version once released and remove the plugin version in the pom of this plugin. |
stefanseifert
requested changes
Jul 14, 2020
stefanseifert
left a comment
stefanseifert
left a comment
Collaborator
There was a problem hiding this comment.
as alternative we could just remove the plugin version immediately, because the mojo-parent 50 that is currently references already contains maven-plugin-plugin 3.5.1 - we forgot to remove the local plugin version when updating to parent 50.
pzygielo
marked this pull request as draft
July 14, 2020 13:30
pzygielo
changed the title
pzygielo
marked this pull request as ready for review
July 14, 2020 13:43
Currently used version generates invalid javadoc for `target/generated-sources/plugin/org/codehaus/mojo/buildhelper/HelpMojo.java`: ```java 346 /** 347 * Splits the specified text into lines of convenient display length. 348 * 349 * @PARAM text The text to split into lines, must not be <code>null</code>. 350 * @PARAM indent The base indentation level of each line, must not be negative. 351 * @PARAM indentSize The size of each indentation, must not be negative. 352 * @PARAM lineLength The length of the line, must not be negative. 353 * @return The sequence of display lines, never <code>null</code>. 354 * @throws NegativeArraySizeException if <code>indent < 0</code> 355 */ 356 private static List<String> toLines( String text, int indent, int indentSize, int lineLength ) ``` where line 354 contains `<` instead of entity. 3.5.1 m-p-p has it fixed (MPLUGIN-324) and comes from current parent.
pzygielo
marked this pull request as draft
July 14, 2020 13:45
Contributor
Author
|
Hmm... it seems I didn't push corrected version. |
pzygielo
marked this pull request as ready for review
July 14, 2020 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently used version generates invalid javadoc for
target/generated-sources/plugin/org/codehaus/mojo/buildhelper/HelpMojo.java:where line 354 contains
<instead of entity.3.5.1 m-p-p has it fixed (MPLUGIN-324) and comes from current parent.