Repository navigation
Test the uptodate goals' mappers in unit tests - #274
Merged
Merged
Conversation
Seven ITs ran a build per mapper type to grep the defined property. UpToDatePropertyTest builds the same file trees with FixtureUtils and asserts the property values; uptodate-multi stays as the IT that covers all mappers through the uptodate-properties goal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight ITs ran a build with
-Xper mapper type (flatten, glob, identity, merge, package, unpackage, and all six at once, up to date and out of date) only to grep which valueuptodate-propertyoruptodate-propertiesdefined.UpToDatePropertyTestbuilds the same file trees withFixtureUtilsfrom the samefixture.properties, moved tosrc/test/resources/uptodatebyte for byte, runs the goals with the same settings, and asserts each property's value. Seven ITs go;uptodate-multistays as the IT for the family.The test was generated from the IT POMs and verify scripts, so its settings and expected values are the ones the ITs encoded.
Verified:
mvn -Prun-its verifyon Maven 3.10.0-rc-1 → 88 unit tests and 45 ITs pass,uptodate-multialso on 4.0.0-rc-7; inverting the timestamp comparison fails the seven up-to-date tests, and dropping theelsevalue fails the out-of-date one.Part of mojohaus/.github#29