Repository navigation
Add literal replacement support to regex property goals - #249
Merged
Merged
Conversation
slachiewicz
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regex replacements currently interpret backslashes and dollar signs in interpolated values, corrupting Windows paths and other literal strings. Add an opt-in
replacementLiteralparameter toregex-propertyand eachregex-propertiessetting. When enabled, the plugin appliesMatcher.quoteReplacement()before replacing matches. The default remainsfalse, preserving existing replacement syntax and regex matching behavior.Document the option with a Windows-path example using
\A.*\zto replace the input once. Add unit and integration coverage for literal backslashes and dollar signs, null and empty replacements, multiple matches, and existing group substitution.Fixes #155
Validation checklist:
regex-propertyandregex-properties.git diff --check.mvn -Dspotless.action=check -Prun-its '-Dinvoker.test=regex-*' -Dinvoker.rerunFailingTestsCount=0 clean verify.@since 3.6.2.mvn -DskipReports siteand verified that the rendered example preserves the regex backslashes and${project.build.directory}expression.Local validation used Linux, Maven 3.9.16, and Eclipse Adoptium Java 26.0.2.