Repository navigation
Fix callable statements with prepareMethod=none (#3070) - #3073
Merged
Divang Sharma (divang) merged 1 commit intoOct 13, 2026
Merged
Conversation
Render procedure arguments as EXEC-safe literals while preserving typed expression formatting. Add regression coverage for temporal, decimal, and unaffected parameter types. --------- Co-authored-by: Divang Sharma <divangsharma@microsoft.com> (cherry picked from commit ab0bc35)
Mahendra Chavan (machavan)
requested review from
Ananya Garg (Ananya2),
Mahendra Chavan (machavan) and
Muskan Gupta (muskan124947)
October 13, 2026 06:36
Ananya Garg (Ananya2)
approved these changes
Oct 13, 2026
Mahendra Chavan (machavan)
approved these changes
Oct 13, 2026
Divang Sharma (divang)
deleted the
user/divang/backport-3070-release-13.6
branch
October 13, 2026 08:18
github-project-automation
Bot
moved this from In progress
to Closed/Merged PRs
in MSSQL JDBC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3070 (merged to main as ab0bc35) to release/13.6.
Problem
With
prepareMethod=none, parameters of a stored procedure call (dates, times, timestamps, and decimals withprecision > 18 or scale > 6) were written as
CAST(...)expressions.CASTis not valid in anEXECargument list, sothe call failed.
Fix
Arguments of a procedure call are now written as plain literals. Parameters of other statements keep the typed form.
Backport notes
git cherry-pick -x), no conflicts, same patch as on main.SQLServerPreparedStatement.javaand the newPrepareMethodNoneCallableStatementTest.java.execution and temp table suites).
Known limitations (same as #3070, documented there)
EXEC, all its parameters are written as plain literals, so a later statement in the sametext, such as
EXEC proc; SELECT ?, returns avarcharinstead of a typed date or decimal.