Fix scrolling in modals - #812
Merged
Merged
Conversation
|
|
||
| let mut hovered_node = None; // Needed for `mouse_down` | ||
| let mut focused_node = None; // Needed for `mouse_down` and `is_click` | ||
| if mouse_down || mouse_up { |
Member
Author
There was a problem hiding this comment.
Whitespace suppression: https://github.com/microsoft/edit/pull/812/changes?w=1
Leonard Hecker (lhecker)
added
C-bug
Dustin L. Howett (DHowett)
approved these changes
Apr 23, 2026
Leonard Hecker (lhecker)
added a commit
that referenced
this pull request
Apr 27, 2026
#812 didn't properly fix dragging and mouse inputs with modifiers. It should be solid now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a node-path check, the order of UI element creation
mattered. Since models are created after the text area this
meant that the text area would steal all scroll input.
This regressed in #603