Repository navigation
Preserve executable permissions for macOS installs - #711
Merged
Merged
Conversation
Cherry-pick of 8ac35c4 from users/embetten/broker-shim-signing-fix-master. ## Summary - Add prebuilt dotnet tool shim runtime identifiers for macOS and Windows. - Include the win-x86 RID. ## Validation - Local restore, publish, and pack validated successfully. - Verified shim entries in the produced nupkg.
Add PackageId and ToolCommandName to csproj (under PackAsTool condition) so that dotnet publish generates shims with: - The correct command name (nuget-plugin-microsoft-artifacts-credential-provider) so dotnet tool install uses the pre-built signed shim instead of generating its own ad-hoc signed one - The correct embedded DLL path matching the tool store layout Update nuspec to include extensionless macOS shims that are not matched by the existing **\*.* glob pattern. Co-authored-by: embetten <embetten@embettens-MacBook-Pro.local>
installcredprovider.sh piped every asset into 'tar xz'. On macOS the self-contained asset is a .zip, and tar does not restore the +x bit stored in the archive, so the CredentialProvider.Microsoft apphost landed without execute permission (GitHub UI/unzip extraction preserved it). Use unzip for .zip assets only, guarded by 'command -v unzip' and falling back to the original 'tar xz' behavior if unzip is unavailable or fails. The .tar.gz path is unchanged. Add a +x check for the self-contained apphost to the Linux/macOS install and release validation templates (bash and sh); guarded by file existence so runtime-dependent (.dll-only) installs are unaffected.
…rovider into users/embetten/install-script+x
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Jonathan Myers (jmyersmsft)
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unzipwith a secure temporary file for macOS archives to preserve the credential provider apphost's executable bit.tarextraction path as a fallback.Fixes #709
Validation