Skip to content

Automatically activate node source map when enabled in tsconfig.json - #33

Merged
mcollina merged 4 commits into
mcollina:mainfrom
Palaxx:feat/auto_activate_source_map
May 21, 2024
Merged

mcollina merged 4 commits into
mcollina:mainfrom
Palaxx:feat/auto_activate_source_map

Conversation

@Palaxx

@Palaxx Palaxx commented May 20, 2024

Copy link
Copy Markdown
Contributor

resolve: #32

This PR will enable source map setting the right variable in NODE_OPTIONS environment variable.

The source map will be enabled only if the tsconfig.json file has the sourceMap field true.

Source map will be enabled both in watch a standard mode

@Palaxx
Palaxx marked this pull request as draft May 20, 2024 12:22
@Palaxx

Palaxx commented May 20, 2024 •

Copy link
Copy Markdown
Contributor Author

I'm able to reproduce the failures in local env with node 20.13.1, everything works with 20.12.
The problem exists also in the main branch

Seems that with 20.13 the tests (from the fixtures) when watch mode active fails with test did not finish before its parent and was cancelled.

@mcollina how do you suggest to proceed?
Could we think to lock the version of node to 20.12 in the pipeline? (probably not)

@mcollina

mcollina commented May 21, 2024 •

Copy link
Copy Markdown
Owner

Please rebase, this is fixed on main.

@Palaxx
Palaxx force-pushed the feat/auto_activate_source_map branch from 7e61e20 to c0acf84 Compare May 21, 2024 09:28
@Palaxx
Palaxx marked this pull request as ready for review May 21, 2024 09:31

@mcollina mcollina left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 2c8349f into mcollina:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Automatically set --enable-source-maps when sourceMap is active in tsConfig.json

2 participants