Add digest re-check before removing followers in synchronization mechanism - #34273
Merged
Merged
Conversation
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
ClearlyClaire
force-pushed
the
fixes/followers-synchronization-double-check
branch
from
March 26, 2025 13:22
c734b54 to
c05ab2f
Compare
Contributor
|
This pull request has resolved merge conflicts and is ready for review. |
ClearlyClaire
marked this pull request as ready for review
March 27, 2025 09:50
Gargron
approved these changes
Mar 28, 2025
vmstan
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follower synchronization mechanism works by computing a digest of follow the expected followers of an account on a remote server, then fetching that collection if needed.
Currently, Mastodon does not re-check the expected digest on the newly-fetched collection, as it assumes any change may just be down to the newly-fetched collection having more up-to-date values.
This PR adds re-checking of the digest before removing any follower, potentially guarding against stale caches and possible other errors, although I'm not sure when this would actually occur.
This also requires that the partial collection features no duplication, even across pages.
Benefits
Drawbacks