Repository navigation
[13.x] Avoid cross-slot reads when checking paused queues - #61139
Merged
taylorotwell merged 1 commit intoAug 12, 2026
Merged
Conversation
lazerg
force-pushed
the
fix/issue-61138-cross-slot-pause-check
branch
from
August 11, 2026 20:26
71ef6e7 to
e15d92d
Compare
Contributor
|
Ye this should work, didn't know about the CROSSSLOT cluster issue :( Kinda wonder if many() should account for that in the case of PhpRedisConnection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #61126,
getPausedQueues()fetches the global pause key in the samemany()call as the per-queue pause keys. On a Redis cache store that becomes a singleMGETover keys that hash to different slots, so any backend with cluster semantics (Redis Cluster, ElastiCache Serverless) replies withCROSSSLOT Keys in request don't hash to the same slot. phpredis signals that by returningfalse, whichPhpRedisConnection::mget()then passes toarray_map(), so the worker sees aTypeErroron every poll and stops consuming jobs.isPaused()batches the two kinds of keys the same way.This reads the global key on its own and batches only the per-queue keys, so a worker polling a single queue is back to reading one key at a time and queues keep running on those backends.
Fixes #61138