Skip to content

ci: add free-disk-space cleanup to test-e2e-podman job - #3557

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
Ankitsinghsisodya:ci/add-free-disk-space-to-e2e-podman-clean
Apr 14, 2026
Merged

knative-prow[bot] merged 1 commit into
knative:mainfrom
Ankitsinghsisodya:ci/add-free-disk-space-to-e2e-podman-clean

Conversation

@Ankitsinghsisodya

Copy link
Copy Markdown
Contributor

Summary

  • Adds endersonmenezes/free-disk-space@v3 step to the test-e2e-podman job, immediately after knative/actions/setup-go@main
  • Makes test-e2e-podman consistent with all other sibling E2E jobs (test-integration, test-e2e, test-e2e-runtimes, test-e2e-config-ci) which already run this cleanup step
  • Podman installation is notably large, making disk pressure more likely in this job than others

Fixes #3553

Copilot AI review requested due to automatic review settings April 1, 2026 08:21
@knative-prow
knative-prow Bot requested review from dsimansk and jrangelramos April 1, 2026 08:21
@knative-prow

knative-prow Bot commented Apr 1, 2026

Copy link
Copy Markdown

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added size/S πŸ€– PR changes 10-29 lines, ignoring generated files. needs-ok-to-test πŸ€– Needs an org member to approve testing labels Apr 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce disk-pressure failures in CI by standardizing the use of a free-disk-space cleanup step in Podman-related workflows, aligning test-e2e-podman with other existing E2E jobs.

Changes:

  • Add endersonmenezes/free-disk-space@v3 cleanup step to the test-e2e-podman job in the main CI workflow.
  • Replace the bespoke β€œRemove Unnecessary Software” shell cleanup in the scheduled Podman Next workflow with the same free-disk-space action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test-podman-next.yaml Replaces manual disk cleanup commands with the shared free-disk-space action in the scheduled Podman Next workflow.
.github/workflows/functions.yaml Adds the free-disk-space action step to test-e2e-podman to match sibling E2E jobs and reduce disk pressure before installing Podman.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test-podman-next.yaml Outdated
All sibling E2E jobs free disk before running; test-e2e-podman was
the only exception. It installs podman (large), so disk pressure is
more likely here than anywhere else.
@knative-prow knative-prow Bot added size/XS πŸ€– PR changes 0-9 lines, ignoring generated files. and removed size/S πŸ€– PR changes 10-29 lines, ignoring generated files. labels Apr 1, 2026
@codecov

codecov Bot commented Apr 1, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 56.25%. Comparing base (e92b074) to head (4ab8502).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3557      +/-   ##
==========================================
+ Coverage   55.52%   56.25%   +0.72%     
==========================================
  Files         180      180              
  Lines       20465    20465              
==========================================
+ Hits        11363    11512     +149     
+ Misses       7902     7754     -148     
+ Partials     1200     1199       -1     
Flag Coverage Ξ”
e2e 36.12% <ΓΈ> (-4.05%) ⬇️
e2e go 32.55% <ΓΈ> (ΓΈ)
e2e node 28.36% <ΓΈ> (ΓΈ)
e2e python 32.91% <ΓΈ> (ΓΈ)
e2e quarkus 28.48% <ΓΈ> (ΓΈ)
e2e rust 27.91% <ΓΈ> (-0.02%) ⬇️
e2e springboot 26.38% <ΓΈ> (+0.02%) ⬆️
e2e typescript 28.47% <ΓΈ> (ΓΈ)
e2e-config-ci 18.14% <ΓΈ> (ΓΈ)
integration 17.43% <ΓΈ> (+0.03%) ⬆️
unit macos-14 43.37% <ΓΈ> (ΓΈ)
unit macos-latest 43.37% <ΓΈ> (ΓΈ)
unit ubuntu-24.04-arm 43.57% <ΓΈ> (ΓΈ)
unit ubuntu-latest 44.25% <ΓΈ> (ΓΈ)
unit windows-latest 43.39% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99

gauron99 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@gauron99 gauron99 closed this Apr 1, 2026
@gauron99 gauron99 reopened this Apr 1, 2026

@lkingland lkingland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm πŸ€– PR is ready to be merged. label Apr 14, 2026
@knative-prow

knative-prow Bot commented Apr 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitsinghsisodya, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved πŸ€– PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026
@knative-prow
knative-prow Bot merged commit 3760ba5 into knative:main Apr 14, 2026
68 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved πŸ€– PR has been approved by an approver from all required OWNERS files. lgtm πŸ€– PR is ready to be merged. needs-ok-to-test πŸ€– Needs an org member to approve testing size/XS πŸ€– PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: test-e2e-podman job missing free-disk-space cleanup step

4 participants