Skip to content

ossfuzz: include zstd seqdec path tests - #1222

Merged
klauspost merged 1 commit into
klauspost:masterfrom
xingyaner:fix-fuzzing
Sep 15, 2026
Merged

klauspost merged 1 commit into
klauspost:masterfrom
xingyaner:fix-fuzzing

Conversation

@xingyaner

@xingyaner xingyaner commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

The OSS-Fuzz zstd fuzz target fails with:

undefined: decodeSyncUsesSafe
undefined: haveSeqdecAsm

seqdec_test.go references these identifiers, which are defined in seqdec_path_test.go and seqdec_path_noasm_test.go. The original fuzzing script renamed seqdec_test.go but did not rename the two files containing the referenced declarations.

Update ossfuzz/ossfuzz.sh to rename both seqdec path test files to *_test_fuzz.go.

Summary by CodeRabbit

  • Tests
    • Expanded OSS-Fuzz build coverage to include additional zstd sequence-decoding tests.

Signed-off-by: xingyaner <longfor2025@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 96cc03d8-6708-4e08-816c-5571c819126f

📥 Commits

Reviewing files that changed from the base of the PR and between a1c49c6 and b65713d.

📒 Files selected for processing (1)
  • ossfuzz/ossfuzz.sh

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Changes

OSS-Fuzz zstd test inclusion

Layer / File(s) Summary
Rename zstd tests for fuzz scope
ossfuzz/ossfuzz.sh
The build script moves seqdec_path_test.go and seqdec_path_noasm_test.go to _fuzz.go filenames before compilation.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b6571

The build-script change should operate correctly in the supported OSS-Fuzz environment, with no remaining merge-blocking issue identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: including the zstd sequence decoder path tests in OSS-Fuzz.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@klauspost
klauspost merged commit de8f55d into klauspost:master Sep 15, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants