[klauspost]

A histogram of a block larger than max block size could cause huff0 to panic. Scale table down on BuildCTable.

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of oversized data histograms in Huffman table construction. The system now rescales histograms exceeding size limits while maintaining relative data distribution, ensuring stable table generation.

• Tests

  • Added test coverage for oversized histogram processing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 434cc968-00a4-4862-8ae7-077a1a20ea23

📥 Commits

Reviewing files that changed from the base of the PR and between ecdb779 and ed100fa.

📒 Files selected for processing (2)

• huff0/build_table.go
• huff0/build_table_test.go

---

📝 Walkthrough

Walkthrough

The PR adds histogram downscaling to BuildCTable when the total count exceeds BlockSizeMax. It computes a right-shift amount and rounding constant, then rescales non-zero symbol counts while preserving relative distribution and ensuring each originally-present symbol remains representable. A new test validates that oversized histograms are successfully scaled and remain valid.

Changes

Histogram Downscaling in BuildCTable

Layer / File(s)	Summary
Histogram downscaling implementation and test huff0/build_table.go, huff0/build_table_test.go	BuildCTable rescales oversized histograms by computing a right-shift and rounding constant, then replacing each non-zero count with a scaled (rounded-up) value. All originally-present symbols remain representable after scaling. TestBuildCTableOversizedTotal validates this behavior with a histogram exceeding BlockSizeMax.

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly Related PRs

• klauspost/compress#1155: Introduces histogram-based BuildCTable implementation that this PR extends with oversized-total downscaling.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: enabling Huffman table building from oversized histograms by implementing scaling logic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch huff0-oversize-table

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}