Repository navigation
phase7-nightly: pin nightly + -Zfixed-x18, build is 0 warnings - #15
Merged
Merged
Conversation
Pins the toolchain to a specific nightly so -Zfixed-x18 is available. Drops the last unactionable build warning (the rust-lang/rust#116344 deprecation that has been hanging on for 4+ phases). Why nightly: - -Zfixed-x18 (modern x18-reservation rustflag) is nightly-only. Bat_OS uses x18 for per-cave bookkeeping and must keep the compiler off it; +reserve-x18 was rust-deprecated. - [unstable] build-std was already in use; on stable that worked by accident, on nightly it's officially supported. The rust-toolchain.toml pin makes both explicit and reproducible. Bump procedure documented inline — don't auto-upgrade. Verification: - cargo build --release --target aarch64-unknown-none --features gicv3: 0 warnings (down from 1 — the reserve-x18 deprecation is gone) - qemu_selftests_smoke.py — all 6 sub-tests PASS - qemu_https_smoke.py — 200 OK from pq.cloudflareresearch.com, hybrid PQ on, body-bytes=6264 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Literal zero warnings on a release build. Pins the toolchain to
nightly-2026-05-06viarust-toolchain.toml, swaps the deprecated-C target-feature=+reserve-x18rustflag for the modern-Zfixed-x18(rust-lang/rust#116344).Why nightly
Two reasons, both pre-existing:
-Zfixed-x18(modern x18-reservation flag) is nightly-only. Bat_OS uses x18 for per-cave bookkeeping and must keep the compiler off it;+reserve-x18was rust-deprecated.[unstable] build-stdwas already in use. On stable it worked by accident; on nightly it's officially supported.The pin makes both explicit and reproducible.
Bump policy
rust-toolchain.tomlhas a# Bump procedurenote inline: don't auto-upgrade. Every nightly bump runs the smokes first; every PR documents which channel it's tested against.Verification
cargo build --release --target aarch64-unknown-none --features gicv3— 0 warnings (was 1: the deprecation)cargo check --target aarch64-unknown-none --features gicv3— 0 warningspython3 scripts/qemu_selftests_smoke.py— all 6 sub-tests PASSpython3 scripts/qemu_https_smoke.py—200 OKfrompq.cloudflareresearch.com, hybrid PQ on,body-bytes=6264. Real HTTPS still works on the new toolchain.Diff scale
rust-toolchain.toml, 18 lines incl. comment).cargo/config.toml— single rustflag swap + 4-line comment refresh)Phase progress
🤖 Generated with claude-flow