Skip to content

docs: fix toHaveProperty example value (2, not tall) - #16268

Merged
SimenB merged 3 commits into
jestjs:mainfrom
EduardF1:docs/fix-tohaveproperty-example
Aug 8, 2026
Merged

SimenB merged 3 commits into
jestjs:mainfrom
EduardF1:docs/fix-tohaveproperty-example

Conversation

@EduardF1

Copy link
Copy Markdown
Contributor

houseForSale['ceiling.height'] is 2, so the example asserts 'tall' would always fail. Corrected to 2 to match the object.

@netlify

netlify Bot commented Jun 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit c326e2b
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/6a76eab55df15500085aab40
😎 Deploy Preview https://deploy-preview-16268--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 29, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: EduardF1 / name: EduardF1 (8545bae)

@pkg-pr-new

pkg-pr-new Bot commented Jun 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16268

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16268

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16268

create-jest

npm i https://pkg.pr.new/create-jest@16268

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16268

expect

npm i https://pkg.pr.new/expect@16268

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16268

jest

npm i https://pkg.pr.new/jest@16268

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16268

jest-circus

npm i https://pkg.pr.new/jest-circus@16268

jest-cli

npm i https://pkg.pr.new/jest-cli@16268

jest-config

npm i https://pkg.pr.new/jest-config@16268

@jest/console

npm i https://pkg.pr.new/@jest/console@16268

@jest/core

npm i https://pkg.pr.new/@jest/core@16268

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16268

jest-diff

npm i https://pkg.pr.new/jest-diff@16268

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16268

jest-each

npm i https://pkg.pr.new/jest-each@16268

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16268

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16268

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16268

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16268

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16268

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16268

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16268

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16268

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16268

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16268

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16268

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16268

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16268

jest-mock

npm i https://pkg.pr.new/jest-mock@16268

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16268

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16268

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16268

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16268

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16268

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16268

jest-runner

npm i https://pkg.pr.new/jest-runner@16268

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16268

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16268

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16268

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16268

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16268

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16268

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16268

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16268

@jest/types

npm i https://pkg.pr.new/@jest/types@16268

jest-util

npm i https://pkg.pr.new/jest-util@16268

jest-validate

npm i https://pkg.pr.new/jest-validate@16268

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16268

jest-worker

npm i https://pkg.pr.new/jest-worker@16268

pretty-format

npm i https://pkg.pr.new/pretty-format@16268

commit: 8545bae

@EduardF1

EduardF1 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

This PR only touches docs/ExpectAPI.md (a one-line fix to the toHaveProperty example value), so the red macOS … jest-jasmine2 job looks unrelated to the change. The single failure is in e2e/__tests__/detectOpenHandles.ts:111 — a timing-sensitive open-handles e2e test — while the rest of the suite passed (1674 passed / 1 failed). Could a maintainer re-run the failed job when convenient? Happy to rebase if that would help. Thanks!

@EduardF1

EduardF1 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Hi maintainers! Just checking in — the CI checks are green and EasyCLA is signed. Let me know if there's anything else needed to get this merged. Thanks!

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB
SimenB merged commit 3487fb6 into jestjs:main Aug 8, 2026
7 checks passed
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants