Repository navigation
Only write heritrix_dmesg.log when requested - #779
Merged
Merged
Conversation
Heritrix.java always created heritrix_dmesg.log in $HERITRIX_HOME, even though only the bin/heritrix script reads it, and only when it starts Heritrix in the background. This got in the way of making $HERITRIX_HOME read-only for Docker and systemd setups. The startup log is now written only when the heritrix.dmesg system property gives its path. bin/heritrix sets this property in background mode and keeps the file in the same place as before. Also fix a typo in bin/heritrix ($startmessage) that stopped it removing a heritrix_dmesg.log left over from a previous start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heritrix.java always created heritrix_dmesg.log in $HERITRIX_HOME, even though only the bin/heritrix script reads it, and only when it starts Heritrix in the background. This got in the way of making $HERITRIX_HOME read-only for Docker and systemd setups.
The startup log is now written only when the heritrix.dmesg system property gives its path. bin/heritrix sets this property in background mode and keeps the file in the same place as before.
Also fix a typo in bin/heritrix ($startmessage) that stopped it removing a heritrix_dmesg.log left over from a previous start.