Repository navigation
Conversation
mdellabitta
self-requested a review
May 15, 2026 20:21
mdellabitta
approved these changes
May 15, 2026
mdellabitta
left a comment
mdellabitta
left a comment
There was a problem hiding this comment.
Looks good! That's a wild problem to have!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a page with an attribute value that is 250MB. We cap that in the regex, but it causes problems when searching for the next attribute and we encounter the \w* while still positioned inside the very large value.