Skip to content

Include sizeOnDisk on Job status - #700

Merged
ato merged 1 commit into
internetarchive:masterfrom
bnfleb:bnf_2025
Dec 11, 2025
Merged

ato merged 1 commit into
internetarchive:masterfrom
bnfleb:bnf_2025

Conversation

@bnfleb

@bnfleb bnfleb commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

See #699
Add sizeOnDisk in sizeTotalsReport tag in the job status api.

  <sizeTotalsReport>
    <dupByHash>0</dupByHash>
    <dupByHashCount>0</dupByHashCount>
    <novel>0</novel>
    <novelCount>0</novelCount>
    <notModified>0</notModified>
    <notModifiedCount>0</notModifiedCount>
    <total>0</total>
    <totalCount>0</totalCount>
    <sizeOnDisk>6011832</sizeOnDisk>
  </sizeTotalsReport>

@ato ato linked an issue Dec 10, 2025 that may be closed by this pull request
@ato
ato merged commit 4ea67a3 into internetarchive:master Dec 11, 2025
3 checks passed
@ato

ato commented Dec 11, 2025 •

Copy link
Copy Markdown
Collaborator

I've merged this but I have some lingering concerns about this one:

  • This obviously won't work if you've reconfigured the WARC output directory.
  • Will enumerating all the WARCs cause performance problems for a large crawl with many files or slower storage? (e.g. remote filesystem mounted over NFS or something)
  • Could WriterPoolProcessor.getTotalBytesWritten() produce the same result without having to read the filesystem? Or are we intentionally adding this because the existing WARCWriter statistics are inaccurate?

ato added a commit that referenced this pull request Dec 11, 2025
@bnfleb

bnfleb commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author
  • If there is a parameter to configure the WARC output directory, we can cahnge the code to use it (but I didn't find it).
  • At the BnF, we have been using this feature for three years on a large scale whitout any performance issue.
  • In principle, WriterPoolProcessor.getTotalBytesWritten() corresponds to the number of uncompressed bytes written. sizeOnDisk is the total size of the compressed warcs.

@bnfleb
bnfleb deleted the bnf_2025 branch August 4, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include sizeOnDisk on Job status

2 participants