Repository navigation
fix: don't restore crawlEndTime when resuming from checkpoint. - #669
Merged
Merged
Conversation
gretchenleighmiller
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crawlEndTimeremains set to-1while a crawl is running, andstatisticsTracker.getCrawlElapsedTime()relies on this to calculate how long the crawl has run.crawlEndTimeis only set to a timestamp when the crawl has terminated, but it is possible to trigger a checkpoint after termination and before teardown. Doing so results in a checkpoint that has a positive value forcrawlEndTime. Resuming from this checkpoint results in a state where the crawl is running, butcrawlEndTimeis set, which can make the elapsed time calculation return a negative value which then breaks theCrawlLimitEnforcermax time limit.