Repository navigation
Fix an old regression in rectangle filling transparency handling - #536
Merged
K4thos merged 1 commit intoMay 26, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit from 2018, @NeatUnsou changed the rendering method in
rmMainSub()so that it does not necessarily use additive blending, which allowed thealpha = -2case to be handled properly: the final colour isdst - src, whereas it used to bedst - src * dst.However when the blend equation change was reflected in
FillRectin this commit the blend function was not modified, so the final blended colour is stilldst - src * dst.