Repository navigation
feat: GetHitVar(power); Projectile and KO fixes - #1593
Merged
Merged
Conversation
- Refactored code a bit to further improve backwards compatibility
- Triggers for power gained on hit or block already existed, but the addition of this one makes the power trigger consistent with the damage triggers, where you can both check the raw Hitdef values as well as the value the char effectively received - Also streamlines common usage of these triggers, as you no longer need to both check Hitpower for when the char gets hit and GuardPower for when the char blocks, with GetHitVar(Power) covering both scenarios - Fixed Getpower not working for Reversaldef
- Like Mugen, targets now exit target lists when they are specifically in state 5150, rather than RoundState 4
potsmugen
changed the title
github-actions
Bot
added
PR: feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added GetHitVar(Power) trigger to return power received from last hit, regardless of getting hit or guarding
Refactored Projectile code a bit to further improve backwards compatibility (Fixes Projectile Tallying f93fc31 Breaks projectile functionality #1512)
Like Mugen, targets now exit target lists when they are specifically in state 5150, rather than RoundState 4 (Fixes Targets get dropped from roundstate 3 to 4 in a specific situation. #1592)