Repository navigation
fix: BG yDelta scrolling speed, camera getting stuck in non-4:3 ratios - #1323
Merged
Merged
Conversation
Camera was getting stuck in a case where floortension was defined and the game had an aspect ratio different from 4:3. The game would try to compensate by modifying drawOffsetY, and this would affect camera BoundLo value. With floortension being defined, the camera would be pushed down a little bit, creating this stuck effect. Also, a bg miscalculation was commented out, since it provoked behavior different from MUGEN 1.1
github-actions
Bot
added
PR: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Camera was getting stuck in a case where floortension was defined and the game had an aspect ratio different from 4:3. The game would try to compensate by modifying drawOffsetY, and this would affect camera BoundLo value. With floortension being defined, the camera would be pushed down by drawOffsetY, potentially creating this stuck effect. Stage initial Y position might be misaligned, though, though it might just be differences in aspect ratio. And tensionhigh/tensionlow behavior needs to be investigated further, since this change might directly affect it.
Also, a bg miscalculation was commented out, since it provoked behavior different from MUGEN 1.1
Thanks to @NeatUnsou for input regarding how to fix ydelta.
Fixes #1319