Skip to content

feat: changes to message triggers, added Just Defended - #1041

Merged
K4thos merged 3 commits into
ikemen-engine:masterfrom
potsmugen:master
Mar 12, 2023
Merged

K4thos merged 3 commits into
ikemen-engine:masterfrom
potsmugen:master

Conversation

@potsmugen

@potsmugen potsmugen commented Mar 11, 2023 •

Copy link
Copy Markdown
Contributor
  • Lifebar messages use the "top" parameter, so new messages are displayed on top and as such are always ordered chronologically
  • Changed Reversal message to have the same meaning as commercial games. That is, performing a special or super move after coming out of MoveType = H
  • The check for a Parry message is different and no longer happens exclusively with characters that parry using a helper with the name "Parry Detection"
  • The "Technical" message no longer checks if "CanRecover" and does not include state 5200, as that particular state is only a transition for the actual ground recovery
  • Added the previously unused Just Defended message

- Lifebar messages use the "top" parameter, so new messages are displayed on top and as such are always ordered chronologically
- Changed Reversal message to have the same meaning as commercial games. That is, performing a special or super move after coming out of MoveType = H
- The check for a Parry message is different and no longer happens exclusively with characters that parry using a helper with the name "Parry Detection"
- The "Technical" message no longer checks if "CanRecover" and does not include state 5200, as that particular state is only a transition for the actual ground recovery

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title matches our git commit title formatting guidelines. All good!

@potsmugen potsmugen changed the title Some changes to message triggers other: Some changes to message triggers Mar 11, 2023
@github-actions github-actions Bot added the PR: other This PR implements a code change that improves performance label Mar 11, 2023
- This message was previously unused. It is now shown even if the character has no Just Defense mechanic, both as an easter egg and as a starting place for people to make their own messages
@github-actions github-actions Bot added PR: other This PR implements a code change that improves performance and removed PR: other This PR implements a code change that improves performance labels Mar 11, 2023
- Fixed missing map resets during roundstate 0
@github-actions github-actions Bot added PR: other This PR implements a code change that improves performance and removed PR: other This PR implements a code change that improves performance labels Mar 11, 2023
@potsmugen potsmugen changed the title other: Some changes to message triggers other: Some changes to message triggers. Added Just Defended Mar 11, 2023
@github-actions github-actions Bot added PR: other This PR implements a code change that improves performance and removed PR: other This PR implements a code change that improves performance labels Mar 11, 2023
@K4thos
K4thos merged commit 45821d8 into ikemen-engine:master Mar 12, 2023
@K4thos K4thos changed the title other: Some changes to message triggers. Added Just Defended feat: Some changes to message triggers. Added Just Defended Mar 18, 2023
@github-actions github-actions Bot added PR: feat This PR implements a new feature and removed PR: other This PR implements a code change that improves performance labels Mar 18, 2023
@K4thos K4thos changed the title feat: Some changes to message triggers. Added Just Defended feat: changes to message triggers, added Just Defended Mar 18, 2023
@github-actions github-actions Bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feat This PR implements a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants