Repository navigation
fix: stop guessing recording name, use stored value - #11918
Merged
jennifer-richards merged 3 commits intoNov 6, 2026
Merged
jennifer-richards merged 3 commits into
jennifer-richards merged 3 commits into
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11918 +/- ##
==========================================
- Coverage 89.27% 89.26% -0.01%
==========================================
Files 343 343
Lines 46813 46803 -10
==========================================
- Hits 41792 41781 -11
- Misses 5021 5022 +1 β View full report in Codecov by Harness. π New features to boost your workflow:
|
This was referenced Oct 22, 2026
Contributor
Author
|
relates to #11572 |
Contributor
Author
|
keeping this as draft until backfilling script from #11932 ran |
β¦-db-value-for-recordings-link
rudimatz
marked this pull request as ready for review
November 6, 2026 15:10
Contributor
Author
|
the backfill script ran on both staging and prod. This logic to stop guessing recording names can now be applied. |
jennifer-richards
approved these changes
Nov 6, 2026
Contributor
Author
|
to test after deployment: the link to "Meetecho session recording" for these will be removed, since no recording exists |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old behavior:
Session recording links pointed at the Meetecho player for every session with a timeslot. When
meetecho_recording_namewas empty, the datatracker made up a name from the group acronym and the start time. That produced dead links for sessions that were never recorded (e.g. IESG telechats), for recordings still being processed, and for sessions that have not happened yet.New behavior:
Makes the field
meetecho_recording_name(set by Meetecho through/api/meeting/session/recording-nameonce recording is available) the only source for the link:Session.session_recording_url()returnsNonewhen no recording name is set. The made-up fallback name (_session_recording_url_label()) is removed.Fixes #9592
Fixes #10541
Fixes #10555
Fixes #8237
Related fix in this PR:
session_buttons_include.htmlare shown when there is a recording URL, not when the session had a live video stream. A live stream does not mean a recording exists.