Skip to content

fix: stop guessing recording name, use stored value - #11918

Merged
jennifer-richards merged 3 commits into
ietf-tools:mainfrom
rudimatz:fix/use-db-value-for-recordings-link
Nov 6, 2026
Merged

jennifer-richards merged 3 commits into
ietf-tools:mainfrom
rudimatz:fix/use-db-value-for-recordings-link

Conversation

@rudimatz

@rudimatz rudimatz commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Old behavior:
Session recording links pointed at the Meetecho player for every session with a timeslot. When meetecho_recording_name was empty, the datatracker made up a name from the group acronym and the start time. That produced dead links for sessions that were never recorded (e.g. IESG telechats), for recordings still being processed, and for sessions that have not happened yet.

New behavior:
Makes the field meetecho_recording_name (set by Meetecho through /api/meeting/session/recording-name once recording is available) the only source for the link:

  • Session.session_recording_url() returns None when no recording name is set. The made-up fallback name (_session_recording_url_label()) is removed.

Fixes #9592
Fixes #10541
Fixes #10555
Fixes #8237

Related fix in this PR:

  • The "Session recording" button and dropdown item in session_buttons_include.html are shown when there is a recording URL, not when the session had a live video stream. A live stream does not mean a recording exists.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 89.26%. Comparing base (f5bed82) to head (ba79cb2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11918      +/-   ##
==========================================
- Coverage   89.27%   89.26%   -0.01%     
==========================================
  Files         343      343              
  Lines       46813    46803      -10     
==========================================
- Hits        41792    41781      -11     
- Misses       5021     5022       +1     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rudimatz

Copy link
Copy Markdown
Contributor Author

relates to #11572

@rudimatz

rudimatz commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

keeping this as draft until backfilling script from #11932 ran

@rudimatz
rudimatz marked this pull request as ready for review November 6, 2026 15:10
@rudimatz

rudimatz commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

the backfill script ran on both staging and prod. This logic to stop guessing recording names can now be applied.

@rudimatz

rudimatz commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

to test after deployment: the link to "Meetecho session recording" for these will be removed, since no recording exists

@jennifer-richards
jennifer-richards merged commit e28db7f into ietf-tools:main Nov 6, 2026
9 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants