Repository navigation
Introduce the recently added character Aino to the roster - #431
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @gridhead, your pull request is larger than the review limit of 150000 diff characters
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new character Aino by adding her assets, data definitions, and tests. The changes are well-structured and follow the project's conventions. I have two points of feedback on the new aino.py file. First, there's a minor style issue with a missing newline at the end of the file. More importantly, I've identified a significant discrepancy between the character's base stats defined in the file and the expected values in the tests, particularly for HP. Please review the provided calculations and verify the character data. Otherwise, the changes look good.
| base: BaseStat = BaseStat(attack=24.8712, defense=60.2248, health_points=942.4567) | ||
| ascn: BaseStat = BaseStat(attack=89.0204, defense=215.6892, health_points=3373.2156) |
There was a problem hiding this comment.
There appears to be a data discrepancy between the character stats defined here and the expected values in test/data/test_char.py. Based on the project's calculation logic, the resulting stats don't match the test data, especially for HP.
Here are my calculations for comparison:
Level 40/50 (Rank 2):
- Calculated HP:
5181.89(Test expects5189.07) - Calculated Attack:
136.75(Test expects137.00) - Calculated Defense:
331.18(Test expects331.12)
Level 80/90 (Rank 6):
- Calculated HP:
10463.28(Test expects10477.11) - Calculated Attack:
276.12(Test expects276.63) - Calculated Defense:
668.76(Test expects668.59)
Could you please verify the base and ascn values for Aino? The difference for HP is quite significant and suggests a potential data entry error in this file or the test file.
| vision: Vision = Vision.hydro | ||
| cons_name: str = "Cistellula Mira" | ||
| afln: str = "Clink-Clank Krumkake Craftshop" | ||
| head: str = "Whimsical Craftsmith" No newline at end of file |
There was a problem hiding this comment.
The file is missing a final newline. According to PEP 8, all Python files should end with a single newline character to prevent issues with some tools and file concatenations.1
| head: str = "Whimsical Craftsmith" | |
| head: str = "Whimsical Craftsmith" | |
Style Guide References
Footnotes
-
PEP 8 recommends that all files should end with a single newline character. ↩
565b4eb to
994bbca
Compare
|
This pull request is now ready for review. 
|
There was a problem hiding this comment.
Sorry @gridhead, your pull request is larger than the review limit of 150000 diff characters
sdglitched
left a comment
sdglitched
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for working on this 😜
sdglitched
left a comment
sdglitched
left a comment
There was a problem hiding this comment.
Please resolve the merge conflicts.
Co-authored-by: Akashdeep Dhar <akashdeep.dhar@gmail.com> Co-authored-by: Claude Code <noreply@anthropic.com>
sdglitched
left a comment
sdglitched
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for working on this 😜
Introduce the recently added character
Ainoto the rosterFixes #428