[gridhead]

Introduce the recently added weapon Moonweaver's Dawn

Fixes #426

Summary by Sourcery

Introduce the new Moonweaver's Dawn sword weapon by defining its data model, registering it in the weapons list, and adding corresponding tests

New Features:

• Add Moonweaver's Dawn sword class with its stats, tier, rarity, and refinement details
• Register Moonweaver's Dawn in the swords mapping

Tests:

• Add unit test entry for Moonweaver's Dawn in data/weap/test_sword.py
• Add weapon configuration test for Moonweaver's Dawn in face/wind/weap/kind/test_sword.py

[sourcery-ai]

Reviewer's Guide

Introduces the new Moonweaver's Dawn sword by adding its implementation, registering it in the swords module, and updating relevant tests to include it.

Entity relationship diagram for sword registration including Moonweaver's Dawn

erDiagram
    SWORD_REGISTRY {
        string name
        Sword class_ref
    }
    MoonweaversDawn {
        string name
        WeaponStat seco_stat
        Tier tier
        Rare rare
        string refi_name
        list refi_list
        string file
    }
    SWORD_REGISTRY ||--|{ MoonweaversDawn : contains

Loading

Class diagram for the new Moonweaver's Dawn sword

classDiagram
    class Sword
    class MoonweaversDawn {
        +name: str = "Moonweaver's Dawn"
        +seco_stat: WeaponStat
        +tier: Tier
        +rare: Rare
        +refi_name: str = "Secret Silver's Testament"
        +refi_list: list[str]
        +file: str = "mwdn"
    }
    Sword <|-- MoonweaversDawn
    class WeaponStat
    class WeaponStatType
    class Tier
    class Rare
    MoonweaversDawn --> WeaponStat
    MoonweaversDawn --> Tier
    MoonweaversDawn --> Rare
    WeaponStat --> WeaponStatType

Loading

File-Level Changes

Change	Details	Files
Implemented the Moonweaver's Dawn weapon class	Created MoonweaversDawn class inheriting from Sword Defined secondary stat, rarity, tier, and refine effect descriptions	gi_loadouts/data/weap/swords/mwdn.py
Registered the new weapon in the swords registry	Imported mwdn module Added entry for "Moonweaver's Dawn" to the sword mapping	gi_loadouts/data/weap/swords/__init__.py
Updated data-layer sword tests to include the new weapon	Added pytest.param for Moonweaver's Dawn in test_sword.py	test/data/weap/test_sword.py
Updated face/wind rule sword tests to include the new weapon	Added pytest.param for Moonweaver's Dawn in face/wind rule tests	test/face/wind/weap/kind/test_sword.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#426	Add the weapon 'Moonweaver's Dawn' to the GI Loadouts roster, including its stats, refinement effects, and tier/rarity information.	✅
#426	Ensure 'Moonweaver's Dawn' is properly registered and accessible in the sword weapon list and mapping.	✅
#426	Add or update tests to include 'Moonweaver's Dawn' in relevant sword weapon test cases.	✅

Possibly linked issues

• Add the recently added weapon Moonweaver's Dawn to the GI Loadouts roster #426: The PR introduces Moonweaver's Dawn weapon by adding its data and tests, directly fulfilling the issue's request.
• Add the recently added weapon Moonweaver's Dawn to the GI Loadouts roster #426: The PR introduces 'Moonweaver's Dawn', a new weapon, directly addressing the issue's request to include new weapons.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gridhead]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces the new weapon Moonweaver's Dawn by adding its data model, registering it, and including corresponding tests. The changes are well-structured and follow the existing patterns in the codebase. I've found one area for improvement regarding code readability in the new weapon's data file, where long strings can be broken up for better maintainability.

[gemini-code-assist]

The strings in refi_list are very long, which harms readability. For better maintainability, you can split them across multiple lines. Python automatically concatenates adjacent string literals.

    refi_list: list[str] = [
        (
            "Increases Elemental Burst DMG by 20%. When the character's Energy Capacity does not exceed 60, "
            "Elemental Burst DMG increases by an additional 16%. When the character's Energy Capacity does not "
            "exceed 40, Elemental Burst DMG increases by an additional 28%."
        ),
        (
            "Increases Elemental Burst DMG by 25%. When the character's Energy Capacity does not exceed 60, "
            "Elemental Burst DMG increases by an additional 20%. When the character's Energy Capacity does not "
            "exceed 40, Elemental Burst DMG increases by an additional 35%."
        ),
        (
            "Increases Elemental Burst DMG by 30%. When the character's Energy Capacity does not exceed 60, "
            "Elemental Burst DMG increases by an additional 24%. When the character's Energy Capacity does not "
            "exceed 40, Elemental Burst DMG increases by an additional 42%."
        ),
        (
            "Increases Elemental Burst DMG by 35%. When the character's Energy Capacity does not exceed 60, "
            "Elemental Burst DMG increases by an additional 28%. When the character's Energy Capacity does not "
            "exceed 40, Elemental Burst DMG increases by an additional 49%."
        ),
        (
            "Increases Elemental Burst DMG by 40%. When the character's Energy Capacity does not exceed 60, "
            "Elemental Burst DMG increases by an additional 32%. When the character's Energy Capacity does not "
            "exceed 40, Elemental Burst DMG increases by an additional 56%."
        ),
    ]

[sourcery-ai]

Sorry @gridhead, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sdglitched]

Please resolve the merge conflict.

[sdglitched]

LGTM 🚀

Thanks for working on this 😜