Repository navigation
Feature/improve invalid token error - #6339
Merged
Merged
Conversation
janHildebrandt98
requested review from
joanlopez and
szkiba
and removed request for
a team
August 26, 2026 08:43
janHildebrandt98
temporarily deployed
to
azure-trusted-signing
August 26, 2026 08:49 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
janHildebrandt98
temporarily deployed
to
azure-trusted-signing
August 26, 2026 08:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
joanlopez
reviewed
Aug 26, 2026
Comment on lines
+64
to
+65
| // the endpoint's normal canned response. For testing how the CLI | ||
| // handles a failing API call (e.g. an invalid/expired token, a 5xx). |
Contributor
There was a problem hiding this comment.
nit; I think this comment can be a bit misleading, as only 401 is really supported, and any other status will cause a panic.
Contributor
Author
There was a problem hiding this comment.
adjusted the comment
janHildebrandt98
temporarily deployed
to
azure-trusted-signing
August 26, 2026 10:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
janHildebrandt98
temporarily deployed
to
azure-trusted-signing
August 26, 2026 11:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Author
|
hint text taken from #6333 |
janHildebrandt98
temporarily deployed
to
azure-trusted-signing
August 26, 2026 11:11 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
janHildebrandt98
temporarily deployed
to
azure-trusted-signing
August 26, 2026 11:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
szkiba
reviewed
Aug 27, 2026
2 tasks
szkiba
approved these changes
Aug 27, 2026
joanlopez
approved these changes
Aug 28, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Tradeoffs
Hint is also visible when cloud login fails (redundant). Accepted for simplicity.
Why?
Checklist
make check) and all pass.Related PR(s)/Issue(s)
Closes #5874