Repository navigation
Remove SingleCounterForRate option from OTEL output - #5830
Merged
Merged
Conversation
Drop the deprecated SingleCounterForRate config option from the OpenTelemetry output. Rate metrics are now always exported as a single counter with a condition attribute (nonzero/zero). The old pair of counters method (.occurred + .total) and its feature flag (K6_OTEL_SINGLE_COUNTER_FOR_RATE) are removed. Resolves: #5185
ankur22
temporarily deployed
to
azure-trusted-signing
April 10, 2026 11:13 — with
GitHub Actions
Inactive
ankur22
temporarily deployed
to
azure-trusted-signing
April 10, 2026 11:15 — with
GitHub Actions
Inactive
ankur22
marked this pull request as ready for review
April 10, 2026 11:22
inancgumus
approved these changes
Apr 17, 2026
codebien
approved these changes
Apr 22, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the deprecated
SingleCounterForRateconfig option and all supporting code from the OpenTelemetry output. Rate metrics are now always exported as a single counter with aconditionattribute (nonzero/zero).Why?
The
SingleCounterForRateoption was added in PR #5164 as a temporary escape hatch so users could revert to the old pair-of-counters behavior (<metric>.occurred+<metric>.total) for one release cycle. The old method had a cold-startup bug where.occurredwas never created if the rate never fired (see #4573).The issue explicitly stated: "This option is temporary and will be removed in the release following its introduction." v2 is the appropriate semver boundary for this removal.
Checklist
make check) and all pass.Related PR(s)/Issue(s)
Ratemetric for opentelemetry outputย #4573Closes #5185