[moko-poi]

What?

Emit a warning log when http.get or http.head are called with more than 2 arguments (url + params).

Why?

http.get and http.head only accept (url, params), unlike http.post and other HTTP methods which accept (url, body, params). Users commonly write
http.get(url, null, params) expecting the same 3-argument signature, which silently ignores the extra params. This warning helps users notice the mistake.

Checklist

• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added tests for my changes.
• I have run linter and tests locally (make check) and all pass.

Related PR(s)/Issue(s)

• Previous attempt: fix/validate-args-length #2823 #3974 (closed due to unaddressed feedback)

Closes #2823

[codebien]

Hey @moko-poi 👋 Thanks for this contribution 🎉

It seems the linter is complaining, can you address that issue, please? The rest of the code sounds good to me, thanks 🙇

[moko-poi]

@codebien Fixed the lll lint errors by splitting the long Warnf calls in http.get/http.head across multiple lines. PTAL 🙏

[codebien]

It doesn't sound the good approach, we should find a way to speed-up things here or even better make the test not time-dependent.

However, any change to address it, should live in a dedicated pull request. For this specific pull request we can just retry.

[moko-poi]

@codebien Thanks for the feedback! You're right, I've reverted the timeout change. I'll retry the CI instead. If the flaky test needs a proper fix, I'll address it in a separate PR.