Skip to content

Drop loadimpact options - #5774

Merged
mstoykov merged 2 commits into
masterfrom
dropLoadimpactOptions
Apr 1, 2026
Merged

mstoykov merged 2 commits into
masterfrom
dropLoadimpactOptions

Conversation

@mstoykov

Copy link
Copy Markdown
Contributor

What?

Drop options.ext.loadimpact support.

Why?

It has been deprecated for well over a year and users should use options.cloud.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

#5569

@mstoykov
mstoykov requested a review from a team as a code owner March 30, 2026 13:37
@mstoykov
mstoykov requested review from ankur22 and codebien and removed request for a team March 30, 2026 13:37
@mstoykov mstoykov added this to the v2.0.0 milestone Mar 30, 2026
@mstoykov
mstoykov changed the base branch from master to v2 March 30, 2026 13:37
@mstoykov

Copy link
Copy Markdown
Contributor Author

This is currently against v2 branch but hopefully that will be merged soon and it will be against master. It just happens to touch code around already merged changes for v2.

@mstoykov
mstoykov temporarily deployed to azure-trusted-signing March 30, 2026 13:43 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing March 30, 2026 13:45 — with GitHub Actions Inactive
codebien
codebien previously approved these changes Mar 31, 2026

@codebien codebien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume they will now start getting auth errors if they haven't yet migrated. @mstoykov is that correct?

@mstoykov

Copy link
Copy Markdown
Contributor Author

@codebien yes - as we completely ignore hte loadimpact options - it will just not send anything to authenticate.

Base automatically changed from v2 to master April 1, 2026 07:34
@mstoykov
mstoykov dismissed codebienโ€™s stale review April 1, 2026 07:34

The base branch was changed.

@mstoykov
mstoykov force-pushed the dropLoadimpactOptions branch from 0bc3b9b to eeef1a2 Compare April 1, 2026 07:35
@mstoykov
mstoykov requested a review from codebien April 1, 2026 07:36
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing April 1, 2026 07:41 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing April 1, 2026 07:43 — with GitHub Actions Inactive
@mstoykov
mstoykov merged commit c0156ee into master Apr 1, 2026
60 of 61 checks passed
@mstoykov
mstoykov deleted the dropLoadimpactOptions branch April 1, 2026 09:59
@mstoykov mstoykov modified the milestones: v2.0.0, v2.0.0-rc1 Apr 22, 2026

This branch was previously deployed

1 inactive deployment
azure-trusted-signing โ€” eeef1a28 Deployed Apr 1, 2026 by mstoykov via sign-packages #8717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants