This repository was archived by the owner on Jun 26, 2026. It is now read-only.
feat: support fetch Headers class - #359
Merged
Merged
Conversation
leahecole
approved these changes
Apr 7, 2025
d-goog
approved these changes
Apr 7, 2025
sofisl
approved these changes
Apr 7, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With new changes on google auth library (v10), headers can come as Fetch Headers, which is not supported by Teeny Request. Due to this mismatch, usage of the new auth lib causes system tests on Node BigQuery to fail (see googleapis/nodejs-bigquery#1458)
CoreOptions.headerswas not updated as it would cause a breaking change and require consumers of the library to check if headers are an object vs Fetch Header. This change make it backward compatible.Towards googleapis/nodejs-bigquery#1458