Skip to content

[API] times Add filters - #9373

Merged
techknowlogick merged 14 commits into
go-gitea:masterfrom
6543-forks:api-times-add-filter
Jan 8, 2020
Merged

[API] times Add filters#9373
techknowlogick merged 14 commits into
go-gitea:masterfrom
6543-forks:api-times-add-filter

Conversation

@6543

@6543 6543 commented Dec 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

extend #9200

@6543 6543 changed the title [WIP] Api times add filter [WIP] [API] times Add filter Dec 16, 2019
@6543 6543 changed the title [WIP] [API] times Add filter [WIP] [API] times Add filters Dec 16, 2019
@6543

6543 commented Dec 16, 2019

Copy link
Copy Markdown
Member Author

note for me: found query arguemt for time based filtering: https://developer.github.com/v3/activity/notifications/#parameters

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 16, 2019
@6543 6543 mentioned this pull request Dec 16, 2019
Merged
18 of 19 tasks
@6543
6543 force-pushed the api-times-add-filter branch 3 times, most recently from 7bd25a2 to b69f116 Compare December 17, 2019 16:45
6543
6543 commented Dec 17, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
6543
6543 commented Dec 17, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
6543
6543 commented Dec 17, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
@6543
6543 force-pushed the api-times-add-filter branch from b69f116 to c8f8a56 Compare December 18, 2019 03:46
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2019
zeripath
zeripath previously requested changes Dec 19, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
@6543
6543 force-pushed the api-times-add-filter branch from 1db3832 to dd1f0ed Compare December 22, 2019 20:24
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread templates/swagger/v1_json.tmpl Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread templates/swagger/v1_json.tmpl Resolved
@6543

6543 commented Dec 22, 2019

Copy link
Copy Markdown
Member Author

@zeripath done :D

zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread routers/api/v1/repo/issue_tracked_time.go Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread templates/swagger/v1_json.tmpl Resolved
zeripath
zeripath reviewed Dec 22, 2019
View reviewed changes
Comment thread templates/swagger/v1_json.tmpl Resolved
@zeripath

zeripath commented Dec 22, 2019

Copy link
Copy Markdown
Contributor

Sorry last bit just need to update the comment to match Swagger.

@zeripath

zeripath commented Dec 22, 2019

Copy link
Copy Markdown
Contributor

Could you add a test or two too?

@6543

6543 commented Dec 22, 2019

Copy link
Copy Markdown
Member Author

@zeripath thats why its still WIP ;)

@6543
times Add filters
8a6c4a0 
(extend go-gitea#9200)
 * add query param for GET functions (created Bevore & after)
 * add test
 * generalize func GetQueryBeforeSince
@6543
6543 force-pushed the api-times-add-filter branch from 910f2f3 to 8a6c4a0 Compare January 2, 2020 21:31
gary-kim
gary-kim approved these changes Jan 7, 2020
View reviewed changes

@gary-kim gary-kim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2020
@6543

6543 commented Jan 8, 2020

Copy link
Copy Markdown
Member Author

ready to merge 🚀

@6543

6543 commented Jan 8, 2020

Copy link
Copy Markdown
Member Author

ping lgtm

@techknowlogick
techknowlogick merged commit 14a9687 into go-gitea:master Jan 8, 2020
@6543
6543 deleted the api-times-add-filter branch January 8, 2020 21:14
@6543 6543 mentioned this pull request Jan 17, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@zeripath zeripath zeripath approved these changes
@gary-kim gary-kim gary-kim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

8 participants

@6543 @zeripath @codecov-io @gary-kim @techknowlogick @lafriks @GiteaBot @lunny