Skip to content

Use ID or Where to instead directly use Get when load object from database - #11925

Merged
lafriks merged 3 commits into
go-gitea:masterfrom
lunny:lunny/xorm_get
Jun 17, 2020
Merged

lafriks merged 3 commits into
go-gitea:masterfrom
lunny:lunny/xorm_get

Conversation

@lunny

@lunny lunny commented Jun 17, 2020 •

Copy link
Copy Markdown
Member

As title. Fix #11921

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 17, 2020
Comment thread models/branches.go Resolved
Comment thread models/branches.go Resolved
Comment thread models/user_mail.go Resolved
Co-authored-by: 6543 <6543@obermui.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2020
@6543

6543 commented Jun 17, 2020

Copy link
Copy Markdown
Member

🚀

@lafriks
lafriks merged commit 1645d4a into go-gitea:master Jun 17, 2020
@lafriks

lafriks commented Jun 17, 2020

Copy link
Copy Markdown
Member

Please send backports

6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 17, 2020
…abase (go-gitea#11925)

* Use ID or Where to instead directly use Get when load object from database

* Apply suggestions from code review

Co-authored-by: 6543 <6543@obermui.de>

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 17, 2020
…abase (go-gitea#11925)

* Use ID or Where to instead directly use Get when load object from database

* Apply suggestions from code review

Co-authored-by: 6543 <6543@obermui.de>
@lafriks lafriks added the backport/done All backports for this PR have been created label Jun 17, 2020
zeripath pushed a commit that referenced this pull request Jun 17, 2020
…abase (#11925) (#11934)

Backport #11925

Use ID or Where to instead directly use Get when load object from database

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zeripath pushed a commit that referenced this pull request Jun 17, 2020
…abase (#11925) (#11935)

Backport #11925

Use ID or Where to instead directly use Get when load object from database

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@lunny
lunny deleted the lunny/xorm_get branch June 23, 2020 14:36
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…abase (go-gitea#11925)

* Use ID or Where to instead directly use Get when load object from database

* Apply suggestions from code review

Co-authored-by: 6543 <6543@obermui.de>

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The usage of xorm get has risk

5 participants