Skip to content

Invalidate comments when file is shortened - #11882

Merged
lafriks merged 2 commits into
go-gitea:masterfrom
zeripath:fix-10686-handle-smaller-commented-file
Jun 14, 2020
Merged

lafriks merged 2 commits into
go-gitea:masterfrom
zeripath:fix-10686-handle-smaller-commented-file

Conversation

@zeripath

Copy link
Copy Markdown
Contributor

Fix #10686

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#10686

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug backport/done All backports for this PR have been created labels Jun 14, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 14, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 14, 2020
@zeripath zeripath added backport/v1.12 and removed backport/done All backports for this PR have been created labels Jun 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 14, 2020
@lafriks
lafriks merged commit 48648d1 into go-gitea:master Jun 14, 2020
@lafriks

lafriks commented Jun 14, 2020

Copy link
Copy Markdown
Member

Please send backport

zeripath added a commit to zeripath/gitea that referenced this pull request Jun 14, 2020
Backport go-gitea#11882

Fix go-gitea#10686

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
zeripath deleted the fix-10686-handle-smaller-commented-file branch June 14, 2020 15:53
techknowlogick pushed a commit that referenced this pull request Jun 15, 2020
Backport #11882

Fix #10686

Signed-off-by: Andrew Thornton <art27@cantab.net>
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 15, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Invalidate comments when file is shortened

Fix go-gitea#10686

Signed-off-by: Andrew Thornton <art27@cantab.net>

* handle 1 line

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code comments are not invalidated if the line they reference is removed

5 participants