[ghost]

This PR adds support to create OAuth2 Applications through the API. The intention is to be able to automate the creation of application programmatically.

Maybe it is related to the issue #8764 and #9210

Tasks:

• Create OAuth2 application
• List existing OAuth2 applications (without secrets)
• Delete an OAuth2 application by its ID
• Add tests for create/list/delete

[ghost]

Added List and Delete methods as requested.

[6543]

great work @IGZgustavomarin only smal nits left and we need some tests

[ghost]

great work @IGZgustavomarin only smal nits left and we need some tests

this is a big project, I've tried to setup my environment for testing but couldn't do it. I'll try again. But any help is welcome.

Also not sure which criteria to follow add tests. Which methods of this PR should be covered?

NOTE: Although, I did manual tests by building/running as a local docker image and sending requests with Postman.

[techknowlogick]

CI Fail with:

modules/convert/convert.go:392:1: exported function ToOAuth2Application should have comment or be unexported

[ghost]

CI Fail with:

modules/convert/convert.go:392:1: exported function ToOAuth2Application should have comment or be unexported

fixed

[codecov-io]

Codecov Report

Merging #10437 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10437      +/-   ##
==========================================
- Coverage   43.75%   43.75%   -0.01%     
==========================================
  Files         586      586              
  Lines       81633    81633              
==========================================
- Hits        35717    35716       -1     
  Misses      41492    41492              
- Partials     4424     4425       +1

Impacted Files	Coverage Δ
modules/process/manager.go	74.69% <0%> (-3.62%)	⬇️
modules/git/command.go	86.95% <0%> (-2.61%)	⬇️
modules/log/file.go	75.52% <0%> (-2.1%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0%> (-1.93%)	⬇️
services/pull/check.go	50% <0%> (-1.22%)	⬇️
services/pull/pull.go	34.89% <0%> (-0.3%)	⬇️
models/error.go	29.23% <0%> (+0.51%)	⬆️
modules/git/repo.go	47.7% <0%> (+0.91%)	⬆️
modules/git/utils.go	70.14% <0%> (+4.47%)	⬆️
modules/indexer/stats/db.go	50% <0%> (+9.37%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e979cb6...3d0c072. Read the comment docs.

[ghost]

Kudos to @6543 for all the time you spent helping me to implement a better features and the tests.

[lunny]

@IGZgustavomarin CI failed.

[ghost]

@IGZgustavomarin CI failed.

Yes, but it fails on different places on each pipeline, and none on TestOAuth2Application features that this PR contains. This are the error messages:

First on testing-amd64 > test-mysql >:

RepoAssignment Invalid repo /go/src/code.gitea.io/gitea/integrations/gitea-integration-mysql/gitea-repositories/user2/repo1.git: no such file or directory
--
314 | release_test.go:65:
315 | Error Trace:	integration_test.go:400
316 | integration_test.go:258
317 | release_test.go:65
318 | Error:      	Not equal:
319 | expected: 200
320 | actual  : 500
321 | Test:       	TestViewReleases
322 | Messages:   	Request: GET /user2/repo1/releases
323 | testlogger.go:73: 2020/02/25 13:02:39 ...ers/routes/routes.go:105:func1() [I] Completed GET /user2/repo1/releases 500 Internal Server Error in 6.060573ms

And then on testing-arm64 > test-sqlite >:

[E] DeleteRepository: database is deadlocked
--
287 | testlogger.go:73: 2020/02/25 12:56:04 ...ers/routes/routes.go:105:func1() [I] Completed DELETE /api/v1/repos/user2/repo-tmp-17?token=fc86029a7982c983a0505fa36c003dce11bcfad8 500 Internal Server Error in 94.444323ms

It doesn't seem related to this feature. Can the tests be run again? Or, in caseyou think this is related with this code, how to start debugging it.

Thanks!

[6543]

@IGZgustavomarin if it CI fail unrelated the easyest way to restart is to push an empty commit: git commit -m 'CI restart' --allow-empty & git push ...

[ghost]

@IGZgustavomarin if it CI fail unrelated the easyest way to restart is to push an empty commit: git commit -m 'CI restart' --allow-empty & git push ...

There were some changes on master branch so I just rebased and pushed again. It seems all green now.

[6543]

the most convenient methot to keep your pull up to date is the "update branch" botton of github
and since a pull is squash-merged it doesnt mather in git history anyway

[6543]

ping lgtm

[6543]

@lunny @adelowo this pull need your review or review-dismiss

[guillep2k]

Ping LG-TM