Repository navigation
server : reject non-object session updates - #31714
Merged
angt merged 1 commit intoNov 5, 2026
Merged
Conversation
Prevent malformed realtime session updates from throwing an uncaught exception and terminating the server Signed-off-by: Adrien Gallouët <angt@huggingface.co>
ServeurpersoCom
approved these changes
Nov 5, 2026
ServeurpersoCom
left a comment
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Since #31632 the reader thread already catches this, so this PR turns a raw json exception into a proper client error rather than fixing a crash.
Nit: "audio" has the same issue a few lines below, {"session": {"audio": 1}} still reaches audio.value("input", ...) and throws, you could guard it the same way.
ggerganov
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Prevent malformed realtime session updates from throwing an uncaught exception and terminating the server
Additional information
Requirements