Repository navigation
GH-3524: Refactor fill_mean_token_embeddings for performance optimization on GPU - #3525
Merged
helpmefindaname merged 3 commits intoAug 23, 2024
Conversation
sheldon-roberts
force-pushed
the
optimize-mean-subtoken-pooling
branch
2 times, most recently
from
August 19, 2024 01:29
59689b2 to
dd73547
Compare
…optimization on GPU
sheldon-roberts
force-pushed
the
optimize-mean-subtoken-pooling
branch
from
August 19, 2024 01:30
dd73547 to
4de7940
Compare
helpmefindaname
approved these changes
Aug 23, 2024
helpmefindaname
left a comment
helpmefindaname
left a comment
Member
There was a problem hiding this comment.
Thank you for contributing this,
I could verify that this is way faster than before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3524
This PR implements the optimization of
fill_mean_token_embeddings, as suggested in the linked issue.