Skip to content

Github actions: upgrade windows-2019 to windows-2022 - #4417

Closed
mnorris11 wants to merge 1 commit into
facebookresearch:mainfrom
mnorris11:export-D77602198
Closed

mnorris11 wants to merge 1 commit into
facebookresearch:mainfrom
mnorris11:export-D77602198

Conversation

@mnorris11

Copy link
Copy Markdown
Contributor

Summary:
I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

Differential Revision: D77602198

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D77602198

mnorris11 pushed a commit to mnorris11/faiss that referenced this pull request Jul 1, 2025
…h#4417)

Summary:

I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

Differential Revision: D77602198
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D77602198

mnorris11 pushed a commit to mnorris11/faiss that referenced this pull request Jul 1, 2025
…h#4417)

Summary:

I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

Differential Revision: D77602198
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D77602198

…h#4417)

Summary:

I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

Differential Revision: D77602198
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D77602198

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 1deb5c6.

samanthawaters8882michaeldonovan added a commit to samanthawaters8882michaeldonovan/faiss that referenced this pull request Oct 12, 2025
Summary:
Pull Request resolved: facebookresearch/faiss#4417

I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

I had to disable one particular test just on Windows: https://github.com/facebookresearch/faiss/actions/runs/16009708984/job/45168727031. I filed T229604116 to fix later.

Reviewed By: junjieqi

Differential Revision: D77602198

fbshipit-source-id: 619bbd02a04e142ae0122b2947491d42818301ce
dimitraseferiadi pushed a commit to dimitraseferiadi/SuCo_CSPG_SHG that referenced this pull request Mar 8, 2026
Summary:
Pull Request resolved: facebookresearch/faiss#4417

I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

I had to disable one particular test just on Windows: https://github.com/facebookresearch/faiss/actions/runs/16009708984/job/45168727031. I filed T229604116 to fix later.

Reviewed By: junjieqi

Differential Revision: D77602198

fbshipit-source-id: 619bbd02a04e142ae0122b2947491d42818301ce
dimitraseferiadi pushed a commit to dimitraseferiadi/SuCo_CSPG_SHG that referenced this pull request Mar 16, 2026
Summary:
Pull Request resolved: facebookresearch/faiss#4417

I noticed it wasn't running:

https://github.com/facebookresearch/faiss/actions/runs/15989932609/job/45150739624?pr=4416

Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045

I had to disable one particular test just on Windows: https://github.com/facebookresearch/faiss/actions/runs/16009708984/job/45168727031. I filed T229604116 to fix later.

Reviewed By: junjieqi

Differential Revision: D77602198

fbshipit-source-id: 619bbd02a04e142ae0122b2947491d42818301ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants