Repository navigation
Remove BUILD_AS_SHARED_LIBRARY settings - #7433
Merged
Merged
Conversation
This settings is apparently deprecated and has been replaced by SIDE_MODULE.
kripken
approved these changes
Nov 2, 2018
| dynamic linking, and will match what the LLVM wasm backend will have. | ||
| See #7312. | ||
| - Invalid -s flags on the command line are now treated as errors. | ||
| - Remove BUILD_AS_SHARED_LIBRRARY setting |
Member
There was a problem hiding this comment.
typo, RR=>R. Also need a period at the end.
Beuc
pushed a commit
to Beuc/emscripten
that referenced
this pull request
Nov 17, 2018
This settings is apparently deprecated and has been replaced by SIDE_MODULE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This settings is apparently deprecated and has been replaced
by SIDE_MODULE.