Skip to content

[20120] TCPSendResources cleanup (backport #4300) - #4512

Merged
MiguelCompany merged 2 commits into
2.10.xfrom
mergify/bp/2.10.x/pr-4300
Mar 15, 2024
Merged

MiguelCompany merged 2 commits into
2.10.xfrom
mergify/bp/2.10.x/pr-4300

Conversation

@mergify

@mergify mergify Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

This is an automatic backport of pull request #4300 done by Mergify.
Cherry-pick of fe11650 has failed:

On branch mergify/bp/2.10.x/pr-4300
Your branch is up to date with 'origin/2.10.x'.

You are currently cherry-picking commit fe116500c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/rtps/builtin/discovery/participant/PDP.cpp
	modified:   src/cpp/rtps/network/NetworkFactory.cpp
	modified:   src/cpp/rtps/network/NetworkFactory.h
	modified:   src/cpp/rtps/participant/RTPSParticipantImpl.cpp
	modified:   src/cpp/rtps/participant/RTPSParticipantImpl.h
	modified:   src/cpp/rtps/transport/UDPSenderResource.hpp
	modified:   src/cpp/rtps/transport/UDPTransportInterface.cpp
	modified:   src/cpp/rtps/transport/UDPTransportInterface.h
	modified:   test/blackbox/common/DatagramInjectionTransport.cpp
	modified:   test/blackbox/common/DatagramInjectionTransport.hpp
	modified:   test/mock/rtps/RTPSParticipantImpl/rtps/participant/RTPSParticipantImpl.h
	modified:   test/unittest/rtps/security/CMakeLists.txt
	deleted:    test/unittest/transport/test_UDPv4Tests.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/rtps/transport/TCPSenderResource.hpp
	both modified:   src/cpp/rtps/transport/TCPTransportInterface.cpp
	both modified:   src/cpp/rtps/transport/TCPTransportInterface.h
	both modified:   test/blackbox/common/BlackboxTestsTransportTCP.cpp
	both modified:   test/unittest/rtps/discovery/CMakeLists.txt
	both modified:   test/unittest/statistics/rtps/CMakeLists.txt
	both modified:   test/unittest/transport/CMakeLists.txt
	both modified:   test/unittest/transport/TCPv4Tests.cpp
	both modified:   test/unittest/transport/TCPv6Tests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify

mergify Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

Cherry-pick of fe11650 has failed:

On branch mergify/bp/2.10.x/pr-4300
Your branch is up to date with 'origin/2.10.x'.

You are currently cherry-picking commit fe116500c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/rtps/builtin/discovery/participant/PDP.cpp
	modified:   src/cpp/rtps/network/NetworkFactory.cpp
	modified:   src/cpp/rtps/network/NetworkFactory.h
	modified:   src/cpp/rtps/participant/RTPSParticipantImpl.cpp
	modified:   src/cpp/rtps/participant/RTPSParticipantImpl.h
	modified:   src/cpp/rtps/transport/UDPSenderResource.hpp
	modified:   src/cpp/rtps/transport/UDPTransportInterface.cpp
	modified:   src/cpp/rtps/transport/UDPTransportInterface.h
	modified:   test/blackbox/common/DatagramInjectionTransport.cpp
	modified:   test/blackbox/common/DatagramInjectionTransport.hpp
	modified:   test/mock/rtps/RTPSParticipantImpl/rtps/participant/RTPSParticipantImpl.h
	modified:   test/unittest/rtps/security/CMakeLists.txt
	deleted:    test/unittest/transport/test_UDPv4Tests.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/rtps/transport/TCPSenderResource.hpp
	both modified:   src/cpp/rtps/transport/TCPTransportInterface.cpp
	both modified:   src/cpp/rtps/transport/TCPTransportInterface.h
	both modified:   test/blackbox/common/BlackboxTestsTransportTCP.cpp
	both modified:   test/unittest/rtps/discovery/CMakeLists.txt
	both modified:   test/unittest/statistics/rtps/CMakeLists.txt
	both modified:   test/unittest/transport/CMakeLists.txt
	both modified:   test/unittest/transport/TCPv4Tests.cpp
	both modified:   test/unittest/transport/TCPv6Tests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added the conflicts Backport PR wich git cherry pick failed label Mar 5, 2024
@mergify mergify Bot mentioned this pull request Mar 5, 2024
12 tasks done
@JesusPoderoso JesusPoderoso added this to the v2.10.4 milestone Mar 6, 2024
@jepemi
jepemi force-pushed the mergify/bp/2.10.x/pr-4300 branch from dd92157 to 1c7fda0 Compare March 11, 2024 13:18
@jepemi
jepemi changed the base branch from 2.10.x to mergify/bp/2.10.x/pr-4396 March 11, 2024 13:18
@jepemi

jepemi commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz added ci-pending PR which CI is running temporarily-blocked PR must be merged after another one and removed conflicts Backport PR wich git cherry pick failed needs rebase labels Mar 11, 2024
@cferreiragonz
cferreiragonz force-pushed the mergify/bp/2.10.x/pr-4396 branch 2 times, most recently from f90dc32 to 43406b3 Compare March 12, 2024 07:34
@cferreiragonz
cferreiragonz force-pushed the mergify/bp/2.10.x/pr-4300 branch from 1c7fda0 to c3c072b Compare March 12, 2024 07:54
Base automatically changed from mergify/bp/2.10.x/pr-4396 to 2.10.x March 12, 2024 19:20
@jepemi

jepemi commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

@Mergifyio rebase

@mergify

mergify Bot commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

rebase

โ˜‘๏ธ Nothing to do

Details
  • -conflict [๐Ÿ“Œ rebase requirement]
  • -closed [๐Ÿ“Œ rebase requirement]
  • queue-position=-1 [๐Ÿ“Œ rebase requirement]

@jepemi
jepemi force-pushed the mergify/bp/2.10.x/pr-4300 branch from c3c072b to 15e5e47 Compare March 13, 2024 07:27
@MiguelCompany MiguelCompany removed the temporarily-blocked PR must be merged after another one label Mar 13, 2024
MiguelCompany
MiguelCompany previously approved these changes Mar 13, 2024
@MiguelCompany

Copy link
Copy Markdown
Member

@Mergifyio rebase

* Refs #20120: Remove unused include

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: TCP event call

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Sanitize transport

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Added tests and minor fixes

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Extended doxygen description and added to versions.md

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Uncrustify

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Add missing header

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Fix tests

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Uncrustify

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: After client-server decision making rebase, not working

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Update

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Fix for chaining-transports

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Add new channel connection status and tests

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Uncrustify

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Add unittests

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Fix deadlock

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Fix unittest

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Fix asio throwing exceptions

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Unnittest untab

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Apply suggestions

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Uncrustify

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Consider wan case + associated tests

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Remove versions.md update

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Fix rebasing wrong deletion

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Delete assert clause

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20120: Apply suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Co-authored-by: EduPonz <eduardoponz@eprosima.com>

Refs #20120: Solve conflicts

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@mergify

mergify Bot commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

rebase

โœ… Branch has been successfully rebased

@MiguelCompany
MiguelCompany force-pushed the mergify/bp/2.10.x/pr-4300 branch from 15e5e47 to 8e7ff80 Compare March 14, 2024 06:54
@MiguelCompany

Copy link
Copy Markdown
Member

@richiprosima Please test this

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@MiguelCompany

Copy link
Copy Markdown
Member

@richiprosima Please test this

@MiguelCompany

Copy link
Copy Markdown
Member

@richiprosima Please test mac

@MiguelCompany
MiguelCompany merged commit 98fb9a9 into 2.10.x Mar 15, 2024
@MiguelCompany
MiguelCompany deleted the mergify/bp/2.10.x/pr-4300 branch March 15, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants