Skip to content

[20511] Add missing virtual destructor for StatisticsAncillary - #4458

Merged
MiguelCompany merged 1 commit into
2.10.xfrom
fix/2.10.x/statistics_missing_virtual_dtor
Mar 6, 2024
Merged

MiguelCompany merged 1 commit into
2.10.xfrom
fix/2.10.x/statistics_missing_virtual_dtor

Conversation

@EduPonz

@EduPonz EduPonz commented Feb 27, 2024

Copy link
Copy Markdown

Description

This PR is a partial backport of #4448 to add a missing virtual destructor.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.10.4 milestone Feb 27, 2024
@EduPonz

EduPonz commented Feb 27, 2024

Copy link
Copy Markdown
Author

@richiprosima please test this

@EduPonz EduPonz mentioned this pull request Feb 27, 2024
7 tasks done
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 27, 2024
@JesusPoderoso

Copy link
Copy Markdown
Contributor

@richiprosima please test mac

@MiguelCompany
MiguelCompany merged commit 9938c20 into 2.10.x Mar 6, 2024
@MiguelCompany
MiguelCompany deleted the fix/2.10.x/statistics_missing_virtual_dtor branch March 6, 2024 10:07
cferreiragonz pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants