Repository navigation
[20504] Just show warning when inconsistency between depth and max_samples_per_instance (backport #4417) - #4440
Merged
Merged
Conversation
Merged
13 tasks done
|
@clalancette this should fix iron from sources as well. Fortunately, the previous PR did not get merged in 2.6mx before we caught it. |
…r_instance (#4417) * Refs #20503. Add regression test Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20503. Show warning when depth > max_samples_per_instance Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20503. Fix InvalidQos tests Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 12201f4)
EduPonz
force-pushed
the
mergify/bp/2.10.x/pr-4417
branch
from
February 23, 2024 16:07
e907ed7 to
65ad680
Compare
|
@richiprosima please test this |
EduPonz
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4417 done by Mergify.
Cherry-pick of 12201f4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com