Skip to content

Fix CI badges in Readme.md - #51085

Merged
RikkiGibson merged 6 commits into
dotnet:masterfrom
MaStr11:fixReadmeCIBadges
Feb 9, 2021
Merged

Fix CI badges in Readme.md#51085
RikkiGibson merged 6 commits into
dotnet:masterfrom
MaStr11:fixReadmeCIBadges

Conversation

@MaStr11

@MaStr11 MaStr11 commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Fix #51005

A gist with the new badges can be found here:

https://gist.github.com/MaStr11/ccfa7ca083457bcb75a09d5c5da49997

@MaStr11
MaStr11 requested a review from a team as a code owner February 9, 2021 11:25
@ghost ghost added the Area-Infrastructure label Feb 9, 2021
@MaStr11

MaStr11 commented Feb 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The following jobs are shown/missing

roslyn-CI

  • roslyn-CI (Build_Unix_Debug)
  • roslyn-CI (Build_Windows_Debug)
  • roslyn-CI (Build_Windows_Release)
  • roslyn-CI (Correctness_Build)
  • roslyn-CI (Correctness_Determinism)
  • roslyn-CI (Correctness_SourceBuild)
  • roslyn-CI (Test_Linux_Debug)
  • roslyn-CI (Test_Linux_Debug_Single_Machine)
  • roslyn-CI (Test_Windows_CoreClr_Debug)
  • roslyn-CI (Test_Windows_CoreClr_Debug_Single_Machine)
  • roslyn-CI (Test_Windows_CoreClr_Release)
  • rosln-CI (Test_Windows_Desktop_Debug_32)
  • roslyn-CI (Test_Windows_Desktop_Debug_64)
  • roslyn-CI (Test_Windows_Desktop_Release_32)
  • roslyn-CI (Test_Windows_Desktop_Release_64)
  • roslyn-CI (Test_Windows_Desktop_Spanish_Release_32)
  • roslyn-CI (Test_macOS_Debug)

roslyn-integration-CI

  • roslyn-integration-CI (VS_Integration debug_32)
  • roslyn-integration-CI (VS_Integration debug_64)
  • roslyn-integration-CI (VS_Integration release_32)
  • roslyn-integration-CI (VS_Integration release_64)

Which of the missing jobs should be integrated and how? According to #51005 (comment) the "Build.." jobs should be added. Should these get a separate paragraph? What about the "Single_Machine" jobs? What about "Correctness_SourceBuild"?

MaStr11
MaStr11 commented Feb 9, 2021
View reviewed changes
Comment thread scripts/generate-badges.ps1 Resolved
Comment thread scripts/generate-badges.ps1 Resolved
Comment thread scripts/generate-badges.ps1 Resolved
Youssef1313
Youssef1313 suggested changes Feb 9, 2021
View reviewed changes

@Youssef1313 Youssef1313 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to paste the script output into the README and commit the README changes.

@MaStr11

MaStr11 commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

The PR is a work in progress until #51085 (comment) is addressed. Until then I use the gist from the PR description, which allows copy/paste without fiddling with the readme.

@RikkiGibson

RikkiGibson commented Feb 9, 2021

Copy link
Copy Markdown
Member

Thank you for your contribution!

According to #51005 (comment) the "Build.." jobs should be added. Should these get a separate paragraph?

Yeah let's put the Build jobs in their own paragraph.

What about the "Single_Machine" jobs?

Let's not include these. They're more about validating a code path in our infrastructure than about validating the product.

What about "Correctness_SourceBuild"?

Yeah, let's include this after the "Build Correctness" column.

@MaStr11

MaStr11 commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

@RikkiGibson The changed overview (including a new "Builds" paragraph) can be found in the gist https://gist.github.com/MaStr11/ccfa7ca083457bcb75a09d5c5da49997

Youssef1313
Youssef1313 reviewed Feb 9, 2021
View reviewed changes
Comment thread scripts/generate-badges.ps1 Outdated
Comment on lines +45 to +46
### Builds
|Branch|Windows Debug|Windows Release|Unix Debug|

@Youssef1313 Youssef1313 Feb 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Some markdown parsers (e.g. kramdown) require a blank line around headings. See MD022.

@RikkiGibson

RikkiGibson commented Feb 9, 2021

Copy link
Copy Markdown
Member

LGTM pending update of the content in-repo :)

@RikkiGibson RikkiGibson added Documentation Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Feb 9, 2021
@RikkiGibson

RikkiGibson commented Feb 9, 2021

Copy link
Copy Markdown
Member

@Youssef1313 did the author address all your concerns?

@RikkiGibson

RikkiGibson commented Feb 9, 2021

Copy link
Copy Markdown
Member

Merging with single sign-off as this is a documentation-only change.

@RikkiGibson
RikkiGibson merged commit 11cc964 into dotnet:master Feb 9, 2021
@ghost ghost added this to the Next milestone Feb 9, 2021
@RikkiGibson

RikkiGibson commented Feb 9, 2021

Copy link
Copy Markdown
Member

Thanks for your contribution @MaStr11!

@MaStr11
MaStr11 deleted the fixReadmeCIBadges branch February 10, 2021 08:20
@RikkiGibson RikkiGibson modified the milestones: Next, 16.10.P1 Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes
+1 more reviewer
@Youssef1313 Youssef1313 Youssef1313 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. Documentation

Projects

None yet

Milestone

16.10.P1

Development

Successfully merging this pull request may close these issues.

README Azure badges shows as unknown

3 participants

@MaStr11 @RikkiGibson @Youssef1313