Repository navigation
Cleanup SwipeView and Propagate BC until we can fix compat layout - #17418
Merged
Merged
Conversation
Member
Author
|
/rebase |
github-actions
Bot
force-pushed
the
swipeview_logical_smawl
branch
from
September 18, 2023 23:46
5a0334f to
a30baff
Compare
jsuarezruiz
approved these changes
Sep 20, 2023
jsuarezruiz
added
area-xaml
Does the nightly build "8.0.0-nightly.9370+sha.d02f597f04-azdo.8493478" include this fix? If so it didn't work. The execute method is not always firing. Sometimes it requires a change (add) in the list for it to fire. Is the RC2 going to be like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Alternative PR for #17410 to avoid more changes inside the base layout class.
Code inside SwipeView kept recreating new
SwipeItemslists which would cause the SwipeItems to re-assign to newSwipItemslists instead of the ones that were part of the original xaml. I don't really know why that code was added. It was added in this #6053 but I tested the issue that PR was for and it works fine with these code changes. The result of that code is that every property change was triggering a new SwipeItems to get instantiated.Issues Fixed
Fixes #17371