Skip to content

Hook up CarouselView Scrolled event on Windows - #14405

Merged
rmarinho merged 1 commit into
mainfrom
fix-12725-1
Apr 5, 2023
Merged

rmarinho merged 1 commit into
mainfrom
fix-12725-1

Conversation

@jfversluis

Copy link
Copy Markdown
Member

Description of Change

The event was unhooked instead of hooked while initializing

Issues Fixed

Fixes #12725

@jfversluis jfversluis added platform/windows area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Apr 5, 2023
@rmarinho

rmarinho commented Apr 5, 2023

Copy link
Copy Markdown
Member

/backport to net7.0

@rmarinho rmarinho added backport/suggested The PR author or issue review has suggested that the change should be backported. backport/approved After some discussion or review, this PR or change was approved to be backported. labels Apr 5, 2023
@github-actions

github-actions Bot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/4618163583

@rmarinho
rmarinho merged commit f748523 into main Apr 5, 2023
@rmarinho
rmarinho deleted the fix-12725-1 branch April 5, 2023 11:53
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView backport/approved After some discussion or review, this PR or change was approved to be backported. backport/suggested The PR author or issue review has suggested that the change should be backported. fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WinUI] CarouselView "Scrolled" event never fires

3 participants