Skip to content

[iOS] Update CollectionView layout when reloading data - #14218

Merged
hartez merged 1 commit into
mainfrom
fix-10163
Mar 29, 2023
Merged

hartez merged 1 commit into
mainfrom
fix-10163

Conversation

@rmarinho

@rmarinho rmarinho commented Mar 27, 2023 •

Copy link
Copy Markdown
Member

Description of Change

Porting change from xamarin/Xamarin.Forms#14341

Seems that when we clear the items from CollectionView that could be a race condition if we are also adding a new item and the UICollectionView clear/reload didn't finished yet.

fixes #10163

@rmarinho
rmarinho requested a review from jsuarezruiz March 27, 2023 15:47
@Eilon Eilon added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Mar 27, 2023
@rmarinho
rmarinho requested a review from hartez March 27, 2023 16:46
@hartez
hartez merged commit f55971c into main Mar 29, 2023
@hartez
hartez deleted the fix-10163 branch March 29, 2023 17:25
@G1Vh

G1Vh commented May 25, 2023

Copy link
Copy Markdown

Backport it to .net7 please.

@bjarnekrottje

bjarnekrottje commented Jul 17, 2023 •

Copy link
Copy Markdown

Can this fix also be implemented in the .NET 7 version of .NET MAUI? I am running into this same issue and would really like it to be fixed. (@rmarinho)

@samhouts samhouts added platform/ios backport/suggested The PR author or issue review has suggested that the change should be backported. labels Jul 19, 2023
@PureWeen

PureWeen commented Aug 2, 2023

Copy link
Copy Markdown
Member

We're still reviewing if we want to backport this PR. The code changes will cause us to call LayoutIfNeeded less often so we need to verify that isn't going to cause other issues.

@hartez hartez added the backport/approved After some discussion or review, this PR or change was approved to be backported. label Aug 16, 2023
@hartez

hartez commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

/backport to net7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/5881966853

@GV1072

GV1072 commented Nov 11, 2023 •

Copy link
Copy Markdown

Hi All,

Below issue is still reproducing in Maui .net7.0 version also.
#10163

At the same time, we are getting below issue with grouping listview also for ios.
#13076

From Xamarin. Froms 5.0 version issues exists. Can anyone please update whether above issues got fixed or not. We are not able to use grouping collection view and list view due to above issues. We hope at least in >NET we can expect the permanent fix for above issues instead of workarounds.

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView backport/approved After some discussion or review, this PR or change was approved to be backported. backport/suggested The PR author or issue review has suggested that the change should be backported. fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Crash during Render after adding items to an ObservableCollection

10 participants