Skip to content

[Rgen] Move the DelegateInfo struct as part of the type info. - #22391

Merged
mandel-macaque merged 2 commits into
mainfrom
dev/mandel/delegate-info-in-type-info
Mar 13, 2025
Merged

mandel-macaque merged 2 commits into
mainfrom
dev/mandel/delegate-info-in-type-info

Conversation

@mandel-macaque

@mandel-macaque mandel-macaque commented Mar 13, 2025 •

Copy link
Copy Markdown
Contributor

This is done to accommodate the fact that we want to be able to generate the trampoline code from a TypeInfo because it's the most general struct that is both used for parameters and return types.

This later will allow use to have factory methods similar to the ones we have that target the trampoline code generation.

This is done to accomodate the fact that we want to be able to generate
the trampoline code from a TypeInfo becuase is the most general struct
that is both used for parameters and return types.

This later will allow use to have factory methods similar to the ones we
have that target the trampoline code generation.
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #b38da28] Build passed (Detect API changes) βœ…

Pipeline on Agent
Hash: b38da28b8b565be6b4d0c237afc5ca9403462bfd [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #b38da28] Build passed (Build packages) βœ…

Pipeline on Agent
Hash: b38da28b8b565be6b4d0c237afc5ca9403462bfd [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #887fc8a] Build passed (Build macOS tests) βœ…

Pipeline on Agent
Hash: 887fc8af3659442bc73ef80013c48d2805d060c3 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )
  • iOS: vsdrops gist ( ❗ Breaking changes ❗ )
  • tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
  • MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
  • macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b38da28b8b565be6b4d0c237afc5ca9403462bfd [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #887fc8a] Tests on macOS M1 - Mac Monterey (12) passed πŸ’»

βœ… All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 887fc8af3659442bc73ef80013c48d2805d060c3 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #887fc8a] Tests on macOS M1 - Mac Ventura (13) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 887fc8af3659442bc73ef80013c48d2805d060c3 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #887fc8a] Tests on macOS arm64 - Mac Sequoia (15) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 887fc8af3659442bc73ef80013c48d2805d060c3 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #887fc8a] Tests on macOS X64 - Mac Sonoma (14) passed πŸ’»

βœ… All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 887fc8af3659442bc73ef80013c48d2805d060c3 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #b38da28] Windows Integration Tests passed πŸ’»

βœ… All Windows Integration Tests passed.

Pipeline on Agent
Hash: b38da28b8b565be6b4d0c237afc5ca9403462bfd [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ”₯ [CI Build #b38da28] Test results πŸ”₯

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 114 tests passed.

Failures

❌ monotouch tests (MacCatalyst)

1 tests failed, 10 tests passed.
Details
  • monotouch-test/Mac Catalyst/Release (static registrar): Failed (Test run failed.
    Tests run: 3188 Passed: 3044 Inconclusive: 13 Failed: 10 Ignored: 134)

Html Report (VSDrops) Download

Successes

βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… framework: All 2 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 4 tests passed. Html Report (VSDrops) Download
βœ… generator: All 5 tests passed. Html Report (VSDrops) Download
βœ… interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 4 tests passed. Html Report (VSDrops) Download
βœ… linker: All 44 tests passed. Html Report (VSDrops) Download
βœ… monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
βœ… monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
βœ… monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… windows: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 4 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: b38da28b8b565be6b4d0c237afc5ca9403462bfd [PR build]

@mandel-macaque
mandel-macaque merged commit d670890 into main Mar 13, 2025
@mandel-macaque
mandel-macaque deleted the dev/mandel/delegate-info-in-type-info branch March 13, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants